Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AUT-3930: Add /cannot-change-security-codes-identity-fail page #2435

Merged
merged 4 commits into from
Jan 13, 2025

Conversation

mattvot
Copy link
Contributor

@mattvot mattvot commented Dec 19, 2024

What

This page can only be accessed by failing to complete an IPV re-verification journey which returns error codes identity_check_failed or identity_did_not_match.

It renders the existing failure page template and add the extra preamble required to explain the identity check failed.

Welsh English
Screenshot 2024-12-19 at 15 50 44 Screenshot 2024-12-19 at 15 50 40

How to review

  • A UCD review has been performed.

@mattvot mattvot requested review from a team as code owners December 19, 2024 15:20
In preparation for adding two new error codes that map to the same event, refactor the existing logic to a map lookup.
@mattvot mattvot force-pushed the AUT-3930/new-error-url branch 2 times, most recently from 7422aee to a4c5430 Compare December 19, 2024 16:18
This page can only be accessed by failing to complete an IPV re-verification journey which returns error codes `identity_check_failed` or `identity_did_not_match`.

The return page is just the existing IPV failure page, which will be modified next.
Take the new `/cannot-change-security-codes-identity-fail` page, render the existing failure page template and add the extra preamble required to explain the identity check failed.
Currently the form submits to the preexisting IPV incomplete page. Instead this should post to it's own path.
@mattvot mattvot force-pushed the AUT-3930/new-error-url branch from a4c5430 to be09b63 Compare December 19, 2024 16:20
@mattvot mattvot marked this pull request as draft December 19, 2024 16:32
@mattvot mattvot marked this pull request as ready for review January 8, 2025 08:33
Copy link
Contributor

@BeckaL BeckaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks sensible to me 👍

@mattvot mattvot merged commit a77eb10 into main Jan 13, 2025
15 checks passed
@mattvot mattvot deleted the AUT-3930/new-error-url branch January 13, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants