DFC-718: Add missing data attributes to trigger navigation tracking #2365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
gtvj
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The initial implementation of GA4 missed some hooks required to fire the navigation tracker from a button. This PR adds the
data-linkanddata-navHTML attributes to the govuk buttons on each pageThe
data-linkvalue for the majority of pages has been defined as/undefined. As the authentication journey has a number of branching paths, this has been discussed with the Analytics team and approved by Sam Evatt.How to review
Install the chrome extension
Tag Assistant CompanionOpen the localhost url via
Add DomainThe tag assistant will start tracking the analytics events which are fired
Confirm that the navigation tracker is firing for each page
You'll see
/undefinedas the path for most of the newly configured pages