BAU: use setup-node action for dependency caching
#1821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whi-tw
changed the title
setup-node action for dependecy cachingsetup-node action for dependency caching
whi-tw
force-pushed
the
BAU/improve-gha-caching
branch
3 times, most recently
from
9dd30e6 to
9687759
Compare
Rather than manually caching via `actions/cache`, we should use the `setup-node` action to cache dependencies.
whi-tw
force-pushed
the
BAU/improve-gha-caching
branch
2 times, most recently
from
e0b66c9 to
c8dfdb4
Compare
Rather than using tags, we should pin actions to specific SHAs to ensure we are running the same version of the action every time. Additionally, introduce a new workflow to ensure that all actions are pinned as such.
whi-tw
force-pushed
the
BAU/improve-gha-caching
branch
from
c8dfdb4 to
84b319f
Compare
|
andrew-moores
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Rather than manually caching via
actions/cache, we should use thesetup-nodeaction to cache dependencies.Also, add dependency-review workflow to alert to dependency issues in PRs.
Finally, pin all dependencies to SHAs, not semver, as in govuk-one-login/authentication-api#4894
How to review
Code Review