BAU: Simplify frontend deployment process #1795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whi-tw
force-pushed
the
BAU/deploy-frontend-better
branch
2 times, most recently
from
26fed20 to
2670f22
Compare
Also: - add actionlint to the pre-commit hooks to check the GitHub Actions - include extra 'standard' checks - run prettier / eslint natively, not via docker which was slow and doesn't cache well - add a github workflow to run pre-commit on PRs
There is no good reason to have these as separate workflows. This can just lead to the deploy workflow pushing a zip with the wrong pull request metadata. Instead, just run both in the same workflow.
If we don't have a label set, dependabot will label the PRs with "dependencies" and with a label identifying the type of dependency that was updated. This makes it easy to filter PRs by dependency type, for more focussed review.
whi-tw
force-pushed
the
BAU/deploy-frontend-better
branch
from
ed47dcc to
b387bdb
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Previously we had two workflows:
The second workflow was triggered by the completion of the first.
This could lead to a situation where due to network slowdowns, two PRs merged in a short space of time could have their metadata (and possibly terraform) mixed up: the checkout stage in the deploy job just pulled the HEAD commit from the repo, regardless of the commit the
build and pushjob was spawned from.In this new single workflow, we build the image and push the terraform within the same workflow run, meaning that race conditions are no longer possible.
Additionally, I've added a concurrency group, to ensure that only one deploy job can run at once.
Finally, I've added an actionlint pre-commit hook and improved the two
nodehooks - instead of building up a docker container each time, it just uses the localnode_modulesfolder and runs the tasks natively. This is far faster.How to review