AUT-1466: Show end of telephone number on MFA resend screen #1694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* includes the last three digits of a user's telephone number in the relevant template, making use of the returnLastCharacters Nunjucks filter * introduces a new test to validate the last three digits of the user's telephone number are included in the response * updates returnLastCharactersOnly to ensure an empty string will be returned if the function receives a non-string argument. I have done this because I found that is possible for the Nunjucks macro to receive a undefined value which it then passed to the function. If this happens, there would have been an error resulting in a 500.
|
di-fabs
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Updates the "Get security code" screen to include the last 3 digits of the users mobile phone number when the user has reached this page having clicked "send the code again" during a sign in journey.
This PR re-implements the change that was later reverted because merging revealed an acceptance test failure associated with the change to the controller (see related PRs below). This PR has cherry picked the previous commit and amended it to not touch the relevant controller.
Screenshots
Get security code (English)
Get security code (Welsh)
How to review
Checklist
Related PRs