Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bau/add service tests #1627

Merged
merged 2 commits into from
May 20, 2024
Merged

Bau/add service tests #1627

merged 2 commits into from
May 20, 2024

Conversation

BeckaL
Copy link
Contributor

@BeckaL BeckaL commented May 17, 2024

What

  • Introduces service tests which were previously missing. This will make it easier to prove the changes we're making in AUT-2578 to send common security headers are correct.
  • Removes an unused service

How to review

  1. Code Review commit by commit

@BeckaL BeckaL marked this pull request as ready for review May 17, 2024 14:12
@BeckaL BeckaL requested review from a team as code owners May 17, 2024 14:12
This is unused and redundant post the orch/auth split, and can be removed. This commit: caa97df removed usage
@BeckaL BeckaL force-pushed the bau/add-service-tests branch 5 times, most recently from a306c3c to dfcb618 Compare May 17, 2024 14:46
These were previously untested. This will make it easier to prove changes to these files are correct in future.

This also introduces a common test helper for service tests, since there is a lot of repetition between the tests"
@BeckaL BeckaL force-pushed the bau/add-service-tests branch from dfcb618 to 8c74d99 Compare May 17, 2024 14:49
@BeckaL BeckaL merged commit c516ca2 into main May 20, 2024
3 checks passed
@BeckaL BeckaL deleted the bau/add-service-tests branch May 20, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants