Aut 2578/use common headers #1625
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeckaL
force-pushed
the
AUT-2578/use-common-headers
branch
from
1637430 to
5618a88
Compare
|
|
||
| const expectedApiCallDetails = { | ||
| expectedPath: API_ENDPOINTS.CHECK_REAUTH_USER, | ||
| expectedHeaders: expectedHeadersFromCommonVarsWithoutSecurityHeaders, |
There was a problem hiding this comment.
Why do we need to pass this? Maybe it could be a way to add additional headers to be checked rather simply passing a constant from the service-test-helper module back to it.
This will help to show the difference when we update the code to use the new getInternalConfigWithSecurityHeaders function
…n in authorize service This ensures that the security headers from the govuk-one-login/frontend-passthrough-headers library are being set on authorize service requests.
BeckaL
force-pushed
the
AUT-2578/use-common-headers
branch
6 times, most recently
from
c26fc3d to
5407f31
Compare
This is unused and redundant post the orch/auth split, and can be removed. This commit: caa97df removed usage
BeckaL
force-pushed
the
AUT-2578/use-common-headers
branch
2 times, most recently
from
bc429eb to
f773959
Compare
These were previously untested. This will make it easier to prove changes to these files are correct in future. This also introduces a common test helper for service tests, since there is a lot of repetition between the tests"
BeckaL
force-pushed
the
AUT-2578/use-common-headers
branch
from
f773959 to
7d650de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
How to review
Checklist
Related PRs