AUT-1984: Rebuild nginx with headers-more module #1561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whi-tw
force-pushed
the
AUT-1984/rebuild-nginx
branch
9 times, most recently
from
b2dcf88 to
13cad52
Compare
Add headers-more module to the nginx build process. This module is required to remove the Server header from the responses. This involved ripping 'Dockerfile.alpine': https://github.com/nginxinc/docker-nginx/blob/4bf0763f4977fff7e9648add59e0540088f3ca9f/modules/Dockerfile.alpine
- Cache yarn dependencies, based on the yarn.lock file - Pre-build the sidecar container and the sidecar httpie container and cache them
whi-tw
force-pushed
the
AUT-1984/rebuild-nginx
branch
from
13cad52 to
5344d1e
Compare
|
dbes-gds
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add and use the nginx headers-more module to remove security headers
from the sidecar nginx.
This involves rebuilding nginx, using the builder dockerfile they provide.
I've used an older version of the dockerfile that doesn't use buildkit: currently, testcontainers doesn't support buildkit
meaning that we'd not be able to test the container with testcontainers, which would make me sad.
How to review