[AUT-1984] Another attempt at getting the sidecar deployed #1470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whi-tw
force-pushed
the
AUT-1984/do-it-again
branch
from
493e4d4 to
30c8d6c
Compare
This allows the test to pass without having to set the APP_ENV envar to 'prod', meaning that the test will pass when run in an IDE. Additionally, the test now tests non-prod environments as well as prod.
whi-tw
force-pushed
the
AUT-1984/do-it-again
branch
from
30c8d6c to
28e3809
Compare
whi-tw
changed the title
These tests ensure all possible requests to the sidecar are tested. Used testcontainers for this - it allows the tests to be completely isolated from each other, and allows for an additional caddy container to be spun up to test the TRUSTED_PROXIES functionality.
whi-tw
force-pushed
the
AUT-1984/do-it-again
branch
2 times, most recently
from
4e21123 to
6e1e57a
Compare
If the `RUNNER_DEBUG` environment variable is set to `1`, the logs from the sidecar container will be streamed to the console. This is useful for debugging test failures. This is automatically set when the GitHub Actions job is rerun with the "Enable debug logging" option checked. Otherwise, the test can be run on the CLI with `RUNNER_DEBUG=1 yarn test:sidecar`
whi-tw
force-pushed
the
AUT-1984/do-it-again
branch
from
fefc28f to
fe2adc3
Compare
whi-tw
changed the title
dbes-gds
approved these changes
Apr 10, 2024
whi-tw
added a commit
that referenced
this pull request
Apr 10, 2024
Revert "Merge pull request #1470 from govuk-one-login/AUT-1984/do-it-again"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
How to review