Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ATO-387: Remove consent required #1448

Merged
merged 2 commits into from
May 29, 2024
Merged

Conversation

hannah-leong
Copy link
Contributor

What

Remove consentRequired and share-info page as no longer needed

How to review

Code review

Change have been demonstrated

Changes to the user interface or content should be demonstrated to Content Design and Interaction Design before being merged. This is to ensure they can make any necessary changes to Figma.

  • Changes to the user interface have been demonstrated

Performance Analysis have been informed of the change

  • Performance Analysis have been informed of the change

Related PRs

To be merged and tested before applying api changes: govuk-one-login/authentication-api#4080

@hannah-leong
Copy link
Contributor Author

Pre-review:

  • Deploy to dev (sandpit) and test it ignores consentRequired field (still being returned by api).
  • Demo to CDID for Figma changes.
  • Inform Performance Analysis

Pre-prod:

  • Test in staging

@hannah-leong hannah-leong marked this pull request as ready for review March 13, 2024 16:16
@hannah-leong hannah-leong requested review from a team as code owners March 13, 2024 16:16
@hannah-leong hannah-leong force-pushed the ATO-387/remove-consentRequired branch from 2189c6d to f2a5ce5 Compare April 26, 2024 12:56
@hannah-leong hannah-leong force-pushed the ATO-387/remove-consentRequired branch from f2a5ce5 to f6d31ac Compare May 13, 2024 16:09
ayoshebby
ayoshebby previously approved these changes May 21, 2024
Copy link
Contributor

@ayoshebby ayoshebby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hannah-leong hannah-leong force-pushed the ATO-387/remove-consentRequired branch from 20a387d to 6821937 Compare May 24, 2024 10:45
Not needed as was reliant on consentRequired
@hannah-leong hannah-leong force-pushed the ATO-387/remove-consentRequired branch from 6821937 to 2a4bb49 Compare May 24, 2024 10:49
Copy link

@hannah-leong hannah-leong requested a review from ayoshebby May 24, 2024 14:33
@hannah-leong hannah-leong merged commit 5c51f36 into main May 29, 2024
5 checks passed
@hannah-leong hannah-leong deleted the ATO-387/remove-consentRequired branch May 29, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants