Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AUT-1643: Create capability to run acceptance tests against a local RP/front-end #1218

Closed
wants to merge 4 commits into from

Conversation

ayoshebby
Copy link
Contributor

What?

  1. Replaced multiple mini stubs in Docker Compose with a single, unified stub.
  2. Implemented an Express-based solution to serve HTML, replicating functionality from existing deployed stubs (e.g., Staging stub)
  3. Introduced a new local endpoint in a standalone micro stub (using Express), replacing the logic in dev-app.js.
  4. This endpoint is now parameterized based on form selection in the UI, similar to what we have for example (without styling) here
  5. Ensured the new endpoint returns a 302 response to localhost:3000, mirroring the behavior of existing local stubs, including cookie setting functionality.

Why?

Allow acceptance tests to run against a local front-end

Change have been demonstrated

Changes to the user interface or content should be demonstrated to Content Design and Interaction Design before being merged. This is to ensure they can make any necessary changes to Figma.

  • Changes to the user interface have been demonstrated

@ayoshebby ayoshebby requested review from a team as code owners November 14, 2023 16:46
app.get("/authorize", (req, res) => {
const authRequest = getAuthorizeRequest(req.query);

console.log("Query parameters passed from form:");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some console.log failing the lint check.

@dbes-gds dbes-gds force-pushed the BAU/better-poc-RP_STUB branch from 6b90a30 to 36d51b2 Compare November 15, 2023 17:23
So that the new stubs can be used when running the app locally.
For better local performance.
@whi-tw
Copy link
Contributor

whi-tw commented Apr 23, 2024

@ayoshebby is this still active / relevant? if so, could you please fix the conflicts, and if not, can it be closed?

@ayoshebby ayoshebby closed this Jun 12, 2024
@BeckaL BeckaL deleted the BAU/better-poc-RP_STUB branch November 27, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants