Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding radio buttons and conditional fields #1194

Conversation

VladGavrilet
Copy link
Contributor

@VladGavrilet VladGavrilet commented Oct 30, 2023

What?

Modified radio buttons to reflect changes described in ticket 1356

Screenshots

Before:

Screenshot 2023-11-03 at 09-37-20 You did not get a security code - GOV UK One Login

Screenshot 2023-11-03 at 09 37 49 Screenshot 2023-11-03 at 09 40 56 Screenshot 2023-11-03 at 09 41 15

After

Screenshot 2023-11-03 at 13 15 35 Screenshot 2023-11-14 at 12 09 54 Screenshot 2023-11-03 at 13 12 24 Screenshot 2023-11-14 at 12 10 15

Change have been demonstrated

Kim Clayden has been informed of the changes and the screenshots necessary have been posted above

@VladGavrilet VladGavrilet force-pushed the origin/AUT-1356/adding-radio-buttons-text-message-to-a-phone-number-from-another-country branch from 2d3b8be to 4e735da Compare October 31, 2023 08:14
@VladGavrilet VladGavrilet force-pushed the origin/AUT-1356/adding-radio-buttons-text-message-to-a-phone-number-from-another-country branch from 4e735da to c3f5c0a Compare October 31, 2023 08:39
@VladGavrilet VladGavrilet reopened this Oct 31, 2023
@VladGavrilet VladGavrilet force-pushed the origin/AUT-1356/adding-radio-buttons-text-message-to-a-phone-number-from-another-country branch 3 times, most recently from dcbac5c to 9cb8e8f Compare November 3, 2023 11:31
@VladGavrilet VladGavrilet marked this pull request as ready for review November 3, 2023 11:40
@VladGavrilet VladGavrilet requested review from a team as code owners November 3, 2023 11:40
@gtvj
Copy link
Contributor

gtvj commented Nov 8, 2023

HI @VladGavrilet 👋🏽 , as discussed I've just tested this and the new field isn't coming through to Zendesk. Looking further, I can see that this is because the necessary changes aren't in place within contact-us-service.ts (which makes the API call). This is a relatively small change and I'd be happy to pair with you on it, if that would be helpful.

Additionally, as we're in the process of introducing SmartAgent (which will be the new destination for contact form submissions), an associated change will be necessary in contact-us-service-smart-agent.ts so that the form works correctly there too. This is a little more involved, as it will likely require a change to the SmartAgent API. I've put a message in the relevant channel to identify who is best to speak to. Again, let me know if there's anything I can help with.

@VladGavrilet VladGavrilet marked this pull request as draft November 8, 2023 11:57
@VladGavrilet VladGavrilet marked this pull request as ready for review November 9, 2023 12:50
@gtvj gtvj self-requested a review November 10, 2023 10:22
Copy link
Contributor

@gtvj gtvj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @VladGavrilet - not sure why my review wasn't showing. I've added myself as a reviewer and submitting a request for changes now.

src/locales/cy/translation.json Outdated Show resolved Hide resolved
Copy link
Contributor

@gtvj gtvj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @VladGavrilet - I've just requested a few changes as described in the comments. Let me know if you'd like to discuss any of these.

@gtvj
Copy link
Contributor

gtvj commented Nov 13, 2023

Hi @VladGavrilet - do you think it's worth updating the screenshots now that the casing issue in the Welsh content has been fixed?

@VladGavrilet VladGavrilet requested a review from gtvj November 14, 2023 10:31
gtvj
gtvj previously approved these changes Nov 14, 2023
Copy link
Contributor

@gtvj gtvj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HI @VladGavrilet - all approved now. Thanks again for all your work on this (and sorry that there ended up being so much back and forth).

@VladGavrilet VladGavrilet force-pushed the origin/AUT-1356/adding-radio-buttons-text-message-to-a-phone-number-from-another-country branch from 4166647 to 3209477 Compare November 14, 2023 16:58
@VladGavrilet VladGavrilet merged commit fded7e8 into main Nov 14, 2023
3 checks passed
@VladGavrilet VladGavrilet deleted the origin/AUT-1356/adding-radio-buttons-text-message-to-a-phone-number-from-another-country branch November 14, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants