-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding radio buttons and conditional fields #1194
Adding radio buttons and conditional fields #1194
Conversation
2d3b8be
to
4e735da
Compare
4e735da
to
c3f5c0a
Compare
dcbac5c
to
9cb8e8f
Compare
HI @VladGavrilet 👋🏽 , as discussed I've just tested this and the new field isn't coming through to Zendesk. Looking further, I can see that this is because the necessary changes aren't in place within Additionally, as we're in the process of introducing SmartAgent (which will be the new destination for contact form submissions), an associated change will be necessary in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @VladGavrilet - not sure why my review wasn't showing. I've added myself as a reviewer and submitting a request for changes now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @VladGavrilet - I've just requested a few changes as described in the comments. Let me know if you'd like to discuss any of these.
Hi @VladGavrilet - do you think it's worth updating the screenshots now that the casing issue in the Welsh content has been fixed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HI @VladGavrilet - all approved now. Thanks again for all your work on this (and sorry that there ended up being so much back and forth).
4166647
to
3209477
Compare
What?
Modified radio buttons to reflect changes described in ticket 1356
Screenshots
Before:
After
Change have been demonstrated
Kim Clayden has been informed of the changes and the screenshots necessary have been posted above