CN-736: Fix "Back" link issue on Contact Forms further information page #1186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change the furtherInformationGet method would only provide a hrefBack property for app journeys. This caused the back link to be empty for other journeys.
gtvj
force-pushed
the
CN-736/fix-issue-with-back-link
branch
from
761d8e6 to
97fbb05
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
gtvj
changed the title
JHjava
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds
hrefBackproperty for non app journeys in thefurtherInformationGetmethod.Why?
Prior to this change the
furtherInformationGetmethod incontact-us-controller.tswould provide ahrefBackproperty to the view for app journeys only. This caused the back link to be empty for other journeys.