BAU: Remove source ip from prove identity callback service

This is no longer required to set the ip in headers, since the common headers library that is now used gets this from the request that we now pass through.
govuk-one-login · May 22, 2024 · d295f68 · d295f68
1 parent fd60171
commit d295f68
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 6 deletions.
diff --git a/src/components/prove-identity-callback/prove-identity-callback-controller.ts b/src/components/prove-identity-callback/prove-identity-callback-controller.ts
@@ -20,7 +20,6 @@ export function proveIdentityCallbackGet(
 
     const response = await service.processIdentity(
       email,
-      req.ip,
       sessionId,
       clientSessionId,
       persistentSessionId,

diff --git a/src/components/prove-identity-callback/prove-identity-callback-service.ts b/src/components/prove-identity-callback/prove-identity-callback-service.ts
@@ -17,7 +17,6 @@ export function proveIdentityCallbackService(
 ): ProveIdentityCallbackServiceInterface {
   const identityProcessed = async function (
     email: string,
-    sourceIp: string,
     sessionId: string,
     clientSessionId: string,
     persistentSessionId: string,
@@ -28,7 +27,6 @@ export function proveIdentityCallbackService(
       { email: email },
       getInternalRequestConfigWithSecurityHeaders(
         {
-          sourceIp: sourceIp,
           sessionId: sessionId,
           clientSessionId: clientSessionId,
           persistentSessionId: persistentSessionId,

diff --git a/src/components/prove-identity-callback/tests/prove-identity-callback-service.test.ts b/src/components/prove-identity-callback/tests/prove-identity-callback-service.test.ts
@@ -41,7 +41,7 @@ describe("prove identity callback service", () => {
       statusText: "OK",
     });
     postStub.resolves(axiosResponse);
-    const { email, sessionId, clientSessionId, ip, diPersistentSessionId } =
+    const { email, sessionId, clientSessionId, diPersistentSessionId } =
       commonVariables;
     const req = createMockRequest(PATH_NAMES.PROVE_IDENTITY, {
       headers: requestHeadersWithIpAndAuditEncoded,
@@ -55,7 +55,6 @@ describe("prove identity callback service", () => {
 
     const result = await service.processIdentity(
       email,
-      ip,
       sessionId,
       clientSessionId,
       diPersistentSessionId,

diff --git a/src/components/prove-identity-callback/types.ts b/src/components/prove-identity-callback/types.ts
@@ -4,7 +4,6 @@ import { Request } from "express";
 export interface ProveIdentityCallbackServiceInterface {
   processIdentity: (
     email: string,
-    sourceIp: string,
     sessionId: string,
     clientSessionId: string,
     persistentSessionId: string,