Skip to content

Commit

Permalink
BAU: Remove source ip from create password service
Browse files Browse the repository at this point in the history
This is no longer required to set the ip in headers, since the common headers library that is now used gets this from the request that we now pass through.
  • Loading branch information
BeckaL committed May 22, 2024
1 parent c0fa336 commit a91f80a
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ export function createPasswordPost(
res.locals.clientSessionId,
req.session.user.email,
req.body.password,
req.ip,
res.locals.persistentSessionId,
req
);
Expand Down
2 changes: 0 additions & 2 deletions src/components/create-password/create-password-service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ export function createPasswordService(
clientSessionId: string,
emailAddress: string,
password: string,
sourceIp: string,
persistentSessionId: string,
req: Request
): Promise<ApiResponseResult<SignUpResponse>> {
Expand All @@ -31,7 +30,6 @@ export function createPasswordService(
{
sessionId: sessionId,
clientSessionId: clientSessionId,
sourceIp: sourceIp,
persistentSessionId: persistentSessionId,
},
req,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ describe("create password service", () => {
const req = createMockRequest(PATH_NAMES.CREATE_ACCOUNT_SET_PASSWORD, {
headers: requestHeadersWithIpAndAuditEncoded,
});
const { email, sessionId, clientSessionId, ip, diPersistentSessionId } =
const { email, sessionId, clientSessionId, diPersistentSessionId } =
commonVariables;
const password = "abcdef";

Expand All @@ -59,7 +59,6 @@ describe("create password service", () => {
clientSessionId,
email,
password,
ip,
diPersistentSessionId,
req
);
Expand Down
1 change: 0 additions & 1 deletion src/components/create-password/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ export interface CreatePasswordServiceInterface {
clientSessionId: string,
emailAddress: string,
password: string,
sourceIp: string,
persistentSessionId: string,
req: Request
) => Promise<ApiResponseResult<SignUpResponse>>;
Expand Down

0 comments on commit a91f80a

Please sign in to comment.