BAU: Remove source ip from check reauth users service

This is no longer required to set the ip in headers, since the common headers library that is now used gets this from the request that we now pass through.
govuk-one-login · May 22, 2024 · 7dc8528 · 7dc8528
1 parent a9fb879
commit 7dc8528
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 6 deletions.
diff --git a/src/components/check-reauth-users/check-reauth-users-service.ts b/src/components/check-reauth-users/check-reauth-users-service.ts
@@ -16,7 +16,6 @@ export function checkReauthUsersService(
     sessionId: string,
     emailAddress: string,
     sub: string,
-    sourceIp: string,
     clientSessionId: string,
     persistentSessionId: string,
     req: Request
@@ -25,7 +24,6 @@ export function checkReauthUsersService(
     const config = getInternalRequestConfigWithSecurityHeaders(
       {
         sessionId,
-        sourceIp,
         validationStatuses: [
           HTTP_STATUS_CODES.OK,
           HTTP_STATUS_CODES.BAD_REQUEST,

diff --git a/src/components/check-reauth-users/tests/check-reauth-user-service.test.ts b/src/components/check-reauth-users/tests/check-reauth-user-service.test.ts
@@ -39,7 +39,7 @@ describe("re-authentication service", () => {
       statusText: "OK",
     });
     postStub.resolves(axiosResponse);
-    const { sessionId, email, ip, clientSessionId, diPersistentSessionId } =
+    const { sessionId, email, clientSessionId, diPersistentSessionId } =
       commonVariables;
     const req = createMockRequest(PATH_NAMES.ENTER_EMAIL_SIGN_IN, {
       headers: requestHeadersWithIpAndAuditEncoded,
@@ -49,7 +49,6 @@ describe("re-authentication service", () => {
       sessionId,
       email,
       SUBJECT,
-      ip,
       clientSessionId,
       diPersistentSessionId,
       req

diff --git a/src/components/check-reauth-users/types.ts b/src/components/check-reauth-users/types.ts
@@ -6,7 +6,6 @@ export interface CheckReauthServiceInterface {
     sessionId: string,
     email: string,
     sub: string,
-    sourceIp: string,
     clientSessionId: string,
     persistentSessionId: string,
     req: Request

diff --git a/src/components/enter-email/enter-email-controller.ts b/src/components/enter-email/enter-email-controller.ts
@@ -77,7 +77,6 @@ export function enterEmailPost(
         sessionId,
         email,
         sub,
-        req.ip,
         clientSessionId,
         persistentSessionId,
         req
-Original file line number
+Diff line change
@@ Expand Up / @@ -77,7 +77,6 @@ export function enterEmailPost( @@
             sessionId,
             email,
             sub,
-            req.ip,
             clientSessionId,
             persistentSessionId,
             req
@@ Expand Down @@