Merge pull request #1603 from govuk-one-login/BAU/remove-landing-service

BAU: Remove landing service
govuk-one-login · May 7, 2024 · 4f6a524 · 4f6a524
2 parents 49e0b5a + aa46393
commit 4f6a524
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 81 deletions.
diff --git a/src/components/landing/landing-service.ts b/src/components/landing/landing-service.ts
diff --git a/src/components/landing/tests/landing-integration.test.ts b/src/components/landing/tests/landing-integration.test.ts
@@ -3,19 +3,14 @@ import { describe } from "mocha";
 import { sinon } from "../../../../test/utils/test-utils";
 import nock = require("nock");
 import decache from "decache";
-import { HTTP_STATUS_CODES, PATH_NAMES } from "../../../app.constants";
-import { LandingServiceInterface, StartAuthResponse } from "../types";
-import { createApiResponse } from "../../../utils/http";
-import { AxiosResponse } from "axios";
+import { PATH_NAMES } from "../../../app.constants";
 
 describe("Integration:: landing", () => {
   let app: any;
 
   before(async () => {
     decache("../../../app");
-    decache("../landing-service");
     decache("../../../middleware/session-middleware");
-    const landingService = require("../landing-service");
     const sessionMiddleware = require("../../../middleware/session-middleware");
     sinon
       .stub(sessionMiddleware, "validateSessionMiddleware")
@@ -30,37 +25,6 @@ describe("Integration:: landing", () => {
         next();
       });
 
-    sinon
-      .stub(landingService, "landingService")
-      .callsFake((): LandingServiceInterface => {
-        async function start() {
-          const fakeAxiosResponse: AxiosResponse = {
-            data: {
-              client: {
-                serviceType: "MANDATORY",
-                clientName: "test-client",
-                scopes: ["openid"],
-                cookieConsentEnabled: true,
-                consentEnabled: true,
-                redirectUri: "http://test-redirect.gov.uk/callback",
-                state: "jasldasl12312",
-                isOneLoginService: false,
-              },
-              user: {
-                consentRequired: true,
-                upliftRequired: false,
-                identityRequired: false,
-                authenticated: false,
-              },
-            },
-            status: HTTP_STATUS_CODES.OK,
-          } as AxiosResponse;
-
-          return createApiResponse<StartAuthResponse>(fakeAxiosResponse);
-        }
-
-        return { start };
-      });
     app = await require("../../../app").createApp();
   });
 

diff --git a/src/components/landing/types.ts b/src/components/landing/types.ts
@@ -1,4 +1,4 @@
-import { ApiResponseResult, DefaultApiResponse } from "../../types";
+import { DefaultApiResponse } from "../../types";
 
 export interface StartAuthResponse extends DefaultApiResponse {
   client: ClientInfo;
@@ -26,12 +26,3 @@ export interface UserSessionInfo {
   docCheckingAppUser: boolean;
   mfaMethodType?: string;
 }
-
-export interface LandingServiceInterface {
-  start: (
-    sessionId: string,
-    clientSessionId: string,
-    sourceIp: string,
-    persistentSessionId: string
-  ) => Promise<ApiResponseResult<StartAuthResponse>>;
-}