AUT-2578: Remove ip reword me

govuk-one-login · May 17, 2024 · 2f51cf8 · 2f51cf8
1 parent 993c2f2
commit 2f51cf8
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 7 deletions.
diff --git a/src/components/authorize/authorize-controller.ts b/src/components/authorize/authorize-controller.ts
@@ -58,7 +58,6 @@ export function authorizeGet(
     const startAuthResponse = await authService.start(
       sessionId,
       clientSessionId,
-      req.ip,
       persistentSessionId,
       req,
       claims.reauthenticate

diff --git a/src/components/authorize/authorize-service.ts b/src/components/authorize/authorize-service.ts
@@ -16,7 +16,6 @@ export function authorizeService(
   const start = async function (
     sessionId: string,
     clientSessionId: string,
-    sourceIp: string,
     persistentSessionId: string,
     req: Request,
     reauthenticate?: string
@@ -31,7 +30,6 @@ export function authorizeService(
         {
           sessionId: sessionId,
           clientSessionId: clientSessionId,
-          sourceIp: sourceIp,
           persistentSessionId: persistentSessionId,
           reauthenticate: reauthenticateOption,
         },

diff --git a/src/components/authorize/tests/authorize-service.test.ts b/src/components/authorize/tests/authorize-service.test.ts
@@ -50,7 +50,6 @@ describe("authorize service", () => {
     service.start(
       sessionId,
       clientSessionId,
-      ip,
       persistentSessionId,
       req,
       "123456"
@@ -69,7 +68,6 @@ describe("authorize service", () => {
     service.start(
       sessionId,
       clientSessionId,
-      ip,
       persistentSessionId,
       req,
       "123456"
@@ -85,7 +83,7 @@ describe("authorize service", () => {
 
   it("sends a request without a reauth header when reauth is not requested", () => {
     process.env.SUPPORT_REAUTHENTICATION = "1";
-    service.start(sessionId, clientSessionId, ip, persistentSessionId, req);
+    service.start(sessionId, clientSessionId, persistentSessionId, req);
 
     expect(
       getStub.calledWithMatch(API_ENDPOINTS.START, {

diff --git a/src/components/authorize/types.ts b/src/components/authorize/types.ts
@@ -22,7 +22,6 @@ export interface AuthorizeServiceInterface {
   start: (
     sessionId: string,
     clientSessionId: string,
-    sourceIp: string,
     persistentSessionId: string,
     req: Request,
     reauthenticate?: string