Skip to content

Commit

Permalink
chore: fully get rid of AppCompat lib (#620)
Browse files Browse the repository at this point in the history
* chore: get rid of AppCompat themes

It's unnecessary in a pure Compose App, we can also decrease the App size after this change.

* deps: remove com.google.android.material:material

We don't need it after dropping AppCompat.
  • Loading branch information
Goooler authored Sep 3, 2024
1 parent b8df982 commit 37af4fc
Show file tree
Hide file tree
Showing 5 changed files with 2 additions and 79 deletions.
1 change: 0 additions & 1 deletion app/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ dependencies {
implementation(libs.androidx.compose.material)
implementation(libs.kotlin)
implementation(libs.kotlinx.coroutines.android)
implementation(libs.material)
implementation(libs.androidx.compose.ui.preview.tooling)
debugImplementation(libs.androidx.compose.ui.tooling)

Expand Down
34 changes: 0 additions & 34 deletions app/src/main/res/values-night/themes.xml

This file was deleted.

26 changes: 0 additions & 26 deletions app/src/main/res/values/colors.xml

This file was deleted.

18 changes: 2 additions & 16 deletions app/src/main/res/values/themes.xml
Original file line number Diff line number Diff line change
Expand Up @@ -14,21 +14,7 @@
limitations under the License.
-->

<resources xmlns:tools="http://schemas.android.com/tools">
<resources>
<!-- Base application theme. -->
<style name="Theme.AndroidMapsCompose" parent="Theme.MaterialComponents.DayNight.DarkActionBar">
<!-- Primary brand color. -->
<item name="colorPrimary">@color/purple_500</item>
<item name="colorPrimaryVariant">@color/purple_700</item>
<item name="colorOnPrimary">@color/white</item>
<!-- Secondary brand color. -->
<item name="colorSecondary">@color/teal_200</item>
<item name="colorSecondaryVariant">@color/teal_700</item>
<item name="colorOnSecondary">@color/black</item>
<!-- Status bar color. -->
<item name="android:statusBarColor" tools:targetApi="l">
?attr/colorPrimaryVariant
</item>
<!-- Customize your theme here. -->
</style>
<style name="Theme.AndroidMapsCompose" parent="android:Theme.Material.Light.NoActionBar" />
</resources>
2 changes: 0 additions & 2 deletions gradle/libs.versions.toml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ junitktx = "1.2.1"
junit = "4.13.2"
kotlin = "2.0.0"
kotlinxCoroutines = "1.8.1"
material = "1.12.0"
mapsktx = "5.1.1"
mapsecrets = "2.0.1"
org-jacoco-core = "0.8.11"
Expand Down Expand Up @@ -41,7 +40,6 @@ kotlinx-coroutines-android = { module = "org.jetbrains.kotlinx:kotlinx-coroutine
maps-ktx-std = { module = "com.google.maps.android:maps-ktx", version.ref = "mapsktx" }
maps-ktx-utils = { module = "com.google.maps.android:maps-utils-ktx", version.ref = "mapsktx" }
maps-secrets-plugin = { module = "com.google.android.libraries.mapsplatform.secrets-gradle-plugin:secrets-gradle-plugin", version.ref = "mapsecrets" }
material = { module = "com.google.android.material:material", version.ref = "material" }
org-jacoco-core = { module = "org.jacoco:org.jacoco.core", version.ref = "org-jacoco-core" }
test-junit = { module = "junit:junit", version.ref = "junit" }

Expand Down

0 comments on commit 37af4fc

Please sign in to comment.