fix: a few Ruby DSL schema dump bug fixes #308
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
product-auto-label
bot
added
the
api: spanner
jarredhawkins
changed the title
:ruby format schema dump bug fixes
jarredhawkins
force-pushed
the
jarred/dumper
branch
from
949f7a2 to
a44602d
Compare
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
1. Make sure `array` types are preserved in the dump
Otherwise restoring from the dump, columns end up dropping the `array` type and coercing things to the base type
1. Consistently sort `storing` data to avoid diffs in committed `structure` file
Right now it's dependent on the ordering of data from `table_columns`, which doesn't specify ordering.
jarredhawkins
force-pushed
the
jarred/dumper
branch
from
a44602d to
abfca21
Compare
| @@ -27,6 +27,8 @@ def prepare_column_options column | |||
| spec = { type: schema_type(column).inspect }.merge! spec | |||
| end | |||
|
|
|||
| spec[:array] = true if column.sql_type.start_with?('ARRAY<') | |||
There was a problem hiding this comment.
feels like there's probably a safer way to determine if a ActiveRecord::ConnectionAdapters::Spanner::Column is ARRAY type, deferring to reviewers here
There was a problem hiding this comment.
I had a look at what is available here, and there isn't really anything else that you could use without changing the underlying fetching of column metadata. That would make this change much bigger, and I don't think there's any real problem with just checking the type name like this.
Make sure
arraytypes are preserved in the dumpOtherwise restoring from the dump, columns end up dropping the
arraytype and coercing things to the base typeConsistently sort
storingdata to avoid diffs in committedstructure.rbfileRight now it's dependent on the ordering of data from
table_columns, which doesn't specify ordering.