Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: translate annotate to tags #267

Merged
merged 4 commits into from
Nov 3, 2023
Merged

feat: translate annotate to tags #267

merged 4 commits into from
Nov 3, 2023

Conversation

olavloite
Copy link
Collaborator

Adds support for adding request and transaction tags through the annotate method.

Fixes #125

@olavloite
feat: translate annotate to tags
b8795bc 
Adds support for adding request and transaction tags through the
annotate method.

Fixes #125
@olavloite olavloite requested a review from a team as a code owner October 30, 2023 17:32
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/ruby-spanner-activerecord API. label Oct 30, 2023
@olavloite olavloite requested a review from hengfengli October 30, 2023 18:17
hengfengli
hengfengli approved these changes Nov 2, 2023
View reviewed changes
Copy link
Collaborator

@hengfengli hengfengli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

examples/snippets/tags/db/migrate/01_create_tables.rb Outdated Show resolved Hide resolved
examples/snippets/tags/db/seeds.rb Outdated Show resolved Hide resolved
examples/snippets/tags/application.rb Show resolved Hide resolved
examples/snippets/tags/application.rb Outdated Show resolved Hide resolved
examples/snippets/tags/application.rb Outdated Show resolved Hide resolved
@olavloite olavloite merged commit 46783df into main Nov 3, 2023
25 checks passed
@olavloite olavloite deleted the support-annotate-as-tags branch November 3, 2023 09:29
@release-please release-please bot mentioned this pull request Nov 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hengfengli hengfengli hengfengli approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/ruby-spanner-activerecord API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: annotate should translate to tagging
2 participants
@olavloite @hengfengli