Skip to content

Commit

Permalink
docs: update README to reference PGAdapter for PG (#263) (#268)
Browse files Browse the repository at this point in the history
The Google Cloud libraries have already dropped suppport for Ruby 2.6, and
now the build is failing because the latest version of the google-protobuf
libraries require 2.7 or higher.

See also https://github.com/googleapis/ruby-spanner-activerecord/actions/runs/6728914269/job/18288964465

* docs: update README to reference PGAdapter for PG

* chore: use a branch-independent link
  • Loading branch information
olavloite authored Nov 3, 2023
1 parent 5060fb5 commit af940ac
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 30 deletions.
4 changes: 1 addition & 3 deletions .github/workflows/acceptance-tests-on-emulator.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
strategy:
max-parallel: 4
matrix:
ruby: ["2.6", "2.7", "3.0", "3.1", "3.2"]
ruby: ["2.7", "3.0", "3.1", "3.2"]
ar: ["~> 6.0.6", "~> 6.1.7", "~> 7.0.4"]
# Exclude combinations that are not supported.
exclude:
Expand All @@ -28,8 +28,6 @@ jobs:
ar: "~> 6.0.6"
- ruby: "3.2"
ar: "~> 6.0.6"
- ruby: "2.6"
ar: "~> 7.0.4"
env:
AR_VERSION: ${{ matrix.ar }}
steps:
Expand Down
4 changes: 1 addition & 3 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
strategy:
max-parallel: 4
matrix:
ruby: ["2.6", "2.7", "3.0", "3.1", "3.2"]
ruby: ["2.7", "3.0", "3.1", "3.2"]
ar: ["~> 6.0.6", "~> 6.1.7", "~> 7.0.4"]
# Exclude combinations that are not supported.
exclude:
Expand All @@ -20,8 +20,6 @@ jobs:
ar: "~> 6.0.6"
- ruby: "3.2"
ar: "~> 6.0.6"
- ruby: "2.6"
ar: "~> 7.0.4"
env:
AR_VERSION: ${{ matrix.ar }}
steps:
Expand Down
14 changes: 1 addition & 13 deletions .github/workflows/nightly-acceptance-tests-on-emulator.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
max-parallel: 4
matrix:
# Run acceptance tests all supported combinations of Ruby and ActiveRecord.
ruby: [2.6, 2.7, 3.0, 3.1, 3.2]
ruby: [2.7, 3.0, 3.1, 3.2]
ar: [6.0.0, 6.0.1, 6.0.2.2, 6.0.3.7, 6.0.4, 6.1.3.2, 6.1.4.7, 6.1.5.1, 6.1.6.1, 7.0.2.4, 7.0.3.1, 7.0.4, 7.0.5, 7.0.6, 7.0.7]
# Exclude combinations that are not supported.
exclude:
Expand Down Expand Up @@ -53,18 +53,6 @@ jobs:
ar: 6.0.3.7
- ruby: 3.2
ar: 6.0.4
- ruby: 2.6
ar: 7.0.2.4
- ruby: 2.6
ar: 7.0.3.1
- ruby: 2.6
ar: 7.0.4
- ruby: 2.6
ar: 7.0.5
- ruby: 2.6
ar: 7.0.6
- ruby: 2.6
ar: 7.0.7
env:
AR_VERSION: ${{ matrix.ar }}
steps:
Expand Down
10 changes: 1 addition & 9 deletions .github/workflows/nightly-unit-tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
max-parallel: 4
matrix:
# Run unit tests all supported combinations of Ruby and ActiveRecord.
ruby: [2.6, 2.7, 3.0, 3.1, 3.2]
ruby: [2.7, 3.0, 3.1, 3.2]
ar: [6.0.0, 6.0.1, 6.0.2.2, 6.0.3.7, 6.0.4, 6.1.3.2, 6.1.4.7, 6.1.5.1, 6.1.6.1, 7.0.2.4, 7.0.3.1, 7.0.4, 7.0.5]
# Exclude combinations that are not supported.
exclude:
Expand Down Expand Up @@ -45,14 +45,6 @@ jobs:
ar: 6.0.3.7
- ruby: 3.2
ar: 6.0.4
- ruby: 2.6
ar: 7.0.2.4
- ruby: 2.6
ar: 7.0.3.1
- ruby: 2.6
ar: 7.0.4
- ruby: 2.6
ar: 7.0.5
env:
AR_VERSION: ${{ matrix.ar }}
steps:
Expand Down
4 changes: 2 additions & 2 deletions activerecord-spanner-adapter.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@ Gem::Specification.new do |spec|
spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename f }
spec.require_paths = ["lib"]

spec.required_ruby_version = ">= 2.5"
spec.required_ruby_version = ">= 2.7"

spec.add_dependency "google-cloud-spanner", "~> 2.10"
spec.add_dependency "google-cloud-spanner", "~> 2.18"
spec.add_runtime_dependency "activerecord", [">= 6.0.0", "< 7.1"]

spec.add_development_dependency "autotest-suffix", "~> 1.1"
Expand Down

0 comments on commit af940ac

Please sign in to comment.