[DSLX] Auto-format documentation examples, enforce in documentation_test.py
#1832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meheff
approved these changes
Jan 7, 2025
allight
reviewed
Jan 7, 2025
allight
approved these changes
Jan 9, 2025
allight
reviewed
Jan 9, 2025
docs_src/dslx_std.md
Outdated
| @@ -549,16 +526,16 @@ dumping values to stdout. For example: | |||
| // bazel run -c opt //xls/dslx:interpreter_main /path/to/dslx/file.x -- --alsologtostderr | |||
There was a problem hiding this comment.
Ugh copybara changes this line to make the doc-test fail due to differing line lengths.
There was a problem hiding this comment.
I think I'll need to fix this internally since the test is new.
There was a problem hiding this comment.
Or actually just moving this note out of the dslx block should be sufficient.
There was a problem hiding this comment.
Ok I think I did what you were looking for here, but LMK if not!
allight
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to make an issue like #1831 not possible going forward via testing.
However, I was also not able to reproduce the issue reported in #1831, even with the directed tests in here cc @mikex-oss it's possible your
dslx_fmttool in that report was stale?