[dev_tools] Add script to check whether header guards are style-compliant. #1828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allight
requested changes
Jan 6, 2025
allight
approved these changes
Jan 7, 2025
hongted
reviewed
Jan 8, 2025
| @@ -42,7 +43,8 @@ def check_header_guard(filepath, expected_guard): | |||
| return False, None | |||
|
|
|||
| def find_h_files(repo_root): | |||
| # Find all .h files within the repo root, excluding xls/contrib and third_party | |||
| # Find all `.h` files within the repo root, excluding `xls/contrib` and | |||
| # `third_party`. | |||
| h_files = [] | |||
| for root, _, files in os.walk(repo_root): | |||
| if 'xls/contrib' in root or 'third_party' in root: | |||
There was a problem hiding this comment.
Is or 'third_party' in root needed? I don't think github has this directory.
There was a problem hiding this comment.
|
Ok so this is in internally? IDK What's going on... |
|
Ok so it looks like the changes for this somehow got merged into 085321c Possibly when I migrated it internally to get it to be rebased something got confused? |
|
Yeah looks like it's there in 085321c#diff-3b262e89fe8114f1dc9c6a69cb0c059f3df0c65a1c59b203ebc29537d8671061 so will close this PR out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And fix up the non-style-compliant ones.
Wrote this because I forgot one in #1827 and realized I should just write this utility to get the dividends down the road.
Simply run as a script from OSS repo root: