Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating primitives names in LVS regression script and SC cdl files #36

Closed
wants to merge 38 commits into from
Closed

Updating primitives names in LVS regression script and SC cdl files #36

wants to merge 38 commits into from

Conversation

FaragElsayed2
Copy link
Collaborator

@FaragElsayed2 FaragElsayed2 commented Aug 11, 2022 •
edited
Loading

Fixes #1

  • Renaming all primitives with its new name except [resistors / sc_diode] in the following files:
    • globalfoundries-pdk-libs-gf180mcu_fd_pr/rules/klayout/lvs/testing/run_regression.py
    • globalfoundries-pdk-libs-gf180mcu_fd_pr/[rules/klayout/lvs/testing/sc_testcases/*.cdl

@FaragElsayed2 FaragElsayed2 changed the title Updating primitives names Updating primitives names part5 Aug 11, 2022
atorkmabrains
atorkmabrains approved these changes Aug 11, 2022
View reviewed changes
Copy link
Collaborator

@atorkmabrains atorkmabrains left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mithro I'm approving this change.

@mithro mithro force-pushed the primitives_names_part5 branch from dc5413c to 4087d56 Compare August 20, 2022 23:48
@FaragElsayed2 FaragElsayed2 changed the title Updating primitives names part5 Updating primitives names in LVS regression script and SC cdl files Aug 21, 2022
@FaragElsayed2 FaragElsayed2 force-pushed the primitives_names_part5 branch from 4087d56 to 077ab8a Compare August 31, 2022 11:04
@FaragElsayed2 FaragElsayed2 force-pushed the primitives_names_part5 branch from 077ab8a to 1724ade Compare August 31, 2022 11:46
@FaragElsayed2
Copy link
Collaborator Author

FaragElsayed2 commented Aug 31, 2022 •
edited
Loading

@mithro Changes are completed including cap_mim as you agreed with @atorkmabrains

atorkmabrains and others added 17 commits November 8, 2022 10:46
@atorkmabrains
Merge pull request #5 from mabrains/resistors_fix
42cf88f 
Fixing all resistor issues.
@atorkmabrains
Merge pull request #6 from mabrains/metaltop_rules
9aa03a3 
Adding missing Metaltop rules MT.2b and MT30.6
@atorkmabrains
Merge branch 'main' into dropdown_menu
110fb83 
Signed-off-by: atorkmabrains <[email protected]>
@atorkmabrains
Merge pull request #7 from mabrains/dropdown_menu
94c614d 
Adding drop down menu for klayout for ease of use of the PDK.
@atorkmabrains
Merge pull request #8 from mabrains/mos_pcell
464ac3a 
Fixing MOSFET Pcell Bulk Tie
@atorkmabrains
Merge pull request #9 from mabrains/gds2txt
7ea0a74 
Adding script that convert gds2txt back and forth
@atorkmabrains
Merge pull request #10 from mabrains/primitives_names_part2
a41eae1 
Updating primitves names for models files
@atorkmabrains
Merge pull request #11 from mabrains/primitives_names_part3
1b7ace2 
 Updating primitves names in lvs rule deck and its README file
@atorkmabrains
Merge pull request #12 from mabrains/primitives_names_part4
93e3836 
Updating primitives names in [ip , manual, extraction checking] testc…
@atorkmabrains
- Updating primitives names.
2806abe
@atorkmabrains
Merge pull request #13 from mabrains/primitives_names_part1
b29b241 
Updating primitives names in cells directory
@atorkmabrains
Merge pull request #14 from mabrains/primitives_names_part7
a66c86c 
Updating primitives names for 'pnp' bjt devices in lvs gds files
@atorkmabrains
Merge pull request #15 from mabrains/primitives_names_part8
ff25543 
Updating primitives names for 'npn' bjt devices in lvs gds files
@atorkmabrains
Merge pull request #16 from mabrains/primitives_names_part10
2221bf6 
Updating primitives names for 'mimcap 1p5fF & mimcap 2p0fF' in lvs gd…
@atorkmabrains
Merge pull request #17 from mabrains/primitives_names_part9
46e5bb8 
Updating primitives names for 'mimcap 1p0fF' in lvs gds files
@atorkmabrains
Merge pull request #18 from mabrains/primitives_names_part6
f5d31cd 
Updating primitives names in cdl files used for LVS testing
@atorkmabrains
Merge branch 'main' into primitives_names_part5
76c5c19 
Signed-off-by: atorkmabrains <[email protected]>
atorkmabrains added a commit to christoph-weiser/globalfoundries-pdk-libs-gf180mcu_fd_pr that referenced this pull request Dec 18, 2022
@atorkmabrains
Merge pull request google#36 from mabrains/trying_modify_deep_preform…
943d3ac 
…ance

modifying main and via1->5 files
@atorkmabrains atorkmabrains deleted the primitives_names_part5 branch October 25, 2023 16:53
@atorkmabrains atorkmabrains restored the primitives_names_part5 branch October 25, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atorkmabrains atorkmabrains atorkmabrains approved these changes

@mithro mithro Awaiting requested review from mithro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix the naming of the primitives to be consistent with skywater-pdk format.
3 participants
@FaragElsayed2 @atorkmabrains @mohanad0mohamed