Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating primitives names in [ip , manual, extraction checking] testcases and Makefile used for testing #35

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

FaragElsayed2
Copy link
Collaborator

@FaragElsayed2 FaragElsayed2 commented Aug 11, 2022

Fixes #1

  • Renaming all primitives with its new name except [resistors / sc_diode] in the following directories and files:

    • globalfoundries-pdk-libs-gf180mcu_fd_pr/rules/klayout/lvs/testing/Makefile
    • globalfoundries-pdk-libs-gf180mcu_fd_pr/rules/klayout/lvs/testing/extraction_checking/
    • globalfoundries-pdk-libs-gf180mcu_fd_pr/rules/klayout/lvs/testing/ip_testcases
    • globalfoundries-pdk-libs-gf180mcu_fd_pr/rules/klayout/lvs/testing/man_testing

@FaragElsayed2 FaragElsayed2 changed the title Updating primitives names Updating primitives names part4 Aug 11, 2022
Copy link
Collaborator

@atorkmabrains atorkmabrains left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mithro I'm approving this change.

@mithro mithro force-pushed the primitives_names_part4 branch from 66b632a to 4cc9d05 Compare August 20, 2022 23:48
@FaragElsayed2 FaragElsayed2 force-pushed the primitives_names_part4 branch from 4cc9d05 to c58ee68 Compare August 21, 2022 13:47
@FaragElsayed2 FaragElsayed2 changed the title Updating primitives names part4 Updating primitives names in [ip / manual, extraction checking] testcases and Makefile used for testing Aug 21, 2022
@FaragElsayed2 FaragElsayed2 changed the title Updating primitives names in [ip / manual, extraction checking] testcases and Makefile used for testing Updating primitives names in [ip , manual, extraction checking] testcases and Makefile used for testing Aug 21, 2022
@FaragElsayed2 FaragElsayed2 force-pushed the primitives_names_part4 branch from c58ee68 to 417b593 Compare August 31, 2022 10:46
@FaragElsayed2
Copy link
Collaborator Author

FaragElsayed2 commented Aug 31, 2022

@mithro Changes are completed including cap_mim as you agreed with @atorkmabrains

atorkmabrains added a commit to christoph-weiser/globalfoundries-pdk-libs-gf180mcu_fd_pr that referenced this pull request Dec 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the naming of the primitives to be consistent with skywater-pdk format.
2 participants