Avoid outputting Python files for already generated types

This may overwrite types that have already been generated and can create unwanted empty files. Fixes #8490
google · Jan 24, 2025 · fae7554 · fae7554
1 parent 4b69b27
commit fae7554
Show file tree

Hide file tree

Showing 8 changed files with 4 additions and 32 deletions.
diff --git a/src/idl_gen_python.cpp b/src/idl_gen_python.cpp
@@ -2686,14 +2686,11 @@ class PythonGenerator : public BaseGenerator {
   bool SaveType(const std::string &defname, const Namespace &ns,
                 const std::string &classcode, const ImportMap &imports,
                 const std::string &mod, bool needs_imports) const {
+    if (classcode.empty()) return true;
+
     std::string code = "";
-    if (classcode.empty()) {
-      BeginFile(LastNamespacePart(ns), false, &code, "", {});
-      code += "# NOTE " + defname + " does not declare any structs or enums\n";
-    } else {
-      BeginFile(LastNamespacePart(ns), needs_imports, &code, mod, imports);
-      code += classcode;
-    }
+    BeginFile(LastNamespacePart(ns), needs_imports, &code, mod, imports);
+    code += classcode;
 
     const std::string directories =
         parser_.opts.one_file ? path_ : namer_.Directories(ns.components);

diff --git a/tests/FromInclude.py b/tests/FromInclude.py
diff --git a/tests/MyGame/OtherNameSpace/FromInclude.py b/tests/MyGame/OtherNameSpace/FromInclude.py
diff --git a/tests/MyGame/OtherNameSpace/TableB.py b/tests/MyGame/OtherNameSpace/TableB.py
diff --git a/tests/MyGame/OtherNameSpace/Unused.py b/tests/MyGame/OtherNameSpace/Unused.py
diff --git a/tests/MyGame/OtherNameSpace/__init__.py b/tests/MyGame/OtherNameSpace/__init__.py
diff --git a/tests/TableA.py b/tests/TableA.py
diff --git a/tests/__init__.py b/tests/__init__.py