Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor GZIP encoding check #199

Merged
merged 2 commits into from
Oct 25, 2023
Merged

Conversation

ndegwamartin
Copy link
Collaborator

Description of what I changed

When determining whether to apply the Gzip header our condition checks for an exact match in the header value passed for Accept-Encoding. This is limiting since various clients by default supply multiple comma separated values e.g. Accept-Encoding: gzip, deflate, br and the server responds according to configuration.

A better approach would be to use the String.contains method to check for the occurrence of the GZip literal.

E2E test

TESTED:

Please replace this with a description of how you tested your PR beyond the
automated e2e/unit tests.

Checklist: I completed these to help reviewers :)

  • I have read and will follow the review process.

  • I am familiar with Google Style Guides for the language I have coded in.

    No? Please take some time and review Java and Python style guides.

  • My IDE is configured to follow the Google code styles.

    No? Unsure? -> configure your IDE.

  • I have added tests to cover my changes. (If you refactored existing code that was well tested you do not have to add tests)

  • I ran mvn clean package right before creating this pull request and added all formatting changes to my commit.

  • All new and existing tests passed.

  • My pull request is based on the latest changes of the master branch.

    No? Unsure? -> execute command git pull --rebase upstream master

@ndegwamartin
Copy link
Collaborator Author

@bashir2 a few things to note with the PR.

  1. The changes doc/design.md documentation are because of applying spotless, let me know if you need me to revert this.
  2. Should we care about case sensitivity when performing the check. There may be a performance implication. So something like acceptEncodingValue.toLowerCase(Locale.ENGLISH).contains(GZIP_ENCODING_VALUE);

Copy link
Collaborator

@bashir2 bashir2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes @ndegwamartin ; just some minor suggestions.

doc/design.md Show resolved Hide resolved
@bashir2 bashir2 merged commit 5c14912 into google:main Oct 25, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants