Updated proto definitions #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copy original proto files to the this directory, so there is a reference easy to see of the source code.
… the Apple/Metal PJRT seems too incomplete.
… genereate script. Updated XLA and PJRT (v0.57) dependencies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
klogflags; list devices before trying to compile.pjrt_c_api.h: copying over from XLA source is now part of the generate program.(breakage here openxla/xla@590b36f#r149134910)
outside our control, not blocking the release here.
Note: I was holding this release for a while, to see if we could get the Mac version to work ... but outside of diving on the C++ build system for Macs and its code, I'm running out of ideas of what can be done from the client (of XLA/PJRT) side. So instead I'm releasing for Linux only, and documenting that the Mac version is broken 😞 Any help on this front is greatly appreciated.