Use github.com/dmarkham/enumer instead of the usual stringer for …

…dtypes.
gomlx · Jul 20, 2024 · ab04fe4 · ab04fe4
1 parent f392cb1
commit ab04fe4
Show file tree

Hide file tree

Showing 4 changed files with 227 additions and 49 deletions.
diff --git a/cmd/dtypes_codegen/enums.go b/cmd/dtypes_codegen/enums.go
@@ -166,5 +166,5 @@ func generateEnums(contents string) {
 	must.M(enumsFromCTemplate.Execute(f, allValues))
 	must.M(exec.Command("gofmt", "-w", DTypeEnumGoFileName).Run())
 	fmt.Printf("Generated %q based on pjrt_c_api.h\n", DTypeEnumGoFileName)
-	must.M(exec.Command("stringer", "-type=DType", DTypeEnumGoFileName).Run())
+	must.M(exec.Command("enumer", "-type=DType", "-yaml", "-json", "-text", "-values", DTypeEnumGoFileName).Run())
 }
diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md
@@ -2,6 +2,7 @@
 
 * Execute.NonDonatable -> Execute.DonateNone
 * Added Execute.SetDonate
+* Use `github.com/dmarkham/enumer` instead of the usual `stringer` for dtypes.
 
 # v0.2.0 GoMLX integration fixes -- GoMLX more extensive tests caught several small issues in Gopjrt.
 

diff --git a/dtypes/dtype_enumer.go b/dtypes/dtype_enumer.go
diff --git a/dtypes/dtype_string.go b/dtypes/dtype_string.go