acme/autocert: include the domain in the SAN of the CSR

[trevordixon]

More compliant with the spec and allows autocert to work
with Pebble (see letsencrypt/pebble#304).

Fixes golang/go#39746.

[trevordixon]

What do you say?

[korve]

Is there any news on this?

[e1fueg0]

Please merge this PR @FiloSottile

[FiloSottile]

Huh, looks like gopherbot didn't fire on this PR and it was not imported into Gerrit.

@golang/release?

[dmitshur]

@FiloSottile GerritBot waits for @googlebot to add a "cla: yes" label before starting work. For some reason that hasn't happened here yet.

[dmitshur]

It should work now. But, from GerritBot logs:

2021/02/19 21:40:32 GitHub: 0/5000 calls remaining; Reset in 7m52.975721092s

It likely shares rate limit with GopherBot, so issue golang/go#44406 may be relevant here.

[gopherbot]

This PR (HEAD: 9860d60) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/crypto/+/294389 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

[gopherbot]

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://golang.org/doc/contribute.html#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://golang.org/s/release
for more details.

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/294389.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Dmitri Shuralyov:

Patch Set 1: Run-TryBot+1 Trust+1

(2 comments)

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/294389.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Go Bot:

Patch Set 1:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=b013cff6

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/294389.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Go Bot:

Patch Set 1:

Build is still in progress...
This change failed on linux-386:
See https://storage.googleapis.com/go-build-log/9a99515c/linux-386_bf3aabda.log

Other builds still in progress; subsequent failure notices suppressed until final report. Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/294389.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Go Bot:

Patch Set 1: TryBot-Result-1

2 of 10 TryBots failed:
Failed on linux-386: https://storage.googleapis.com/go-build-log/9a99515c/linux-386_bf3aabda.log
Failed on windows-386-2008: https://storage.googleapis.com/go-build-log/9a99515c/windows-386-2008_dcefecdd.log

Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/294389.
After addressing review feedback, remember to publish your drafts!

[e1fueg0]

@FiloSottile could you please tell when we should wait for PR merge?

[gopherbot]

Message from Filippo Valsorda:

Patch Set 1:

(2 comments)

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/294389.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

This PR (HEAD: a89da5c) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/crypto/+/294389 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

[gopherbot]

This PR (HEAD: 25182f8) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/crypto/+/294389 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

[gopherbot]

Message from Trevor Dixon:

Patch Set 5:

(3 comments)

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/294389.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Filippo Valsorda:

Patch Set 5: Run-TryBot+1 Code-Review+2

(1 comment)

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/294389.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Filippo Valsorda:

Patch Set 6: Run-TryBot+1 Code-Review+2

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/294389.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Go Bot:

Patch Set 6:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=73bd57ce

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/294389.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Go Bot:

Patch Set 6: TryBot-Result+1

TryBots are happy.

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/294389.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

This PR (HEAD: b9fca96) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/crypto/+/294389 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

[gopherbot]

Message from Trevor Dixon:

Patch Set 7:

(1 comment)

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/294389.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

This PR (HEAD: 777115c) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/crypto/+/294389 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

[gopherbot]

Message from Filippo Valsorda:

Patch Set 8: Run-TryBot+1 Code-Review+2

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/294389.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Go Bot:

Patch Set 8:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=d904df59

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/294389.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Go Bot:

Patch Set 8: TryBot-Result+1

TryBots are happy.

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/294389.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

This PR is being closed because golang.org/cl/294389 has been merged.