-
-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow unicode class names #1574
Conversation
This will fail tests until the upstream Godot PR is merged |
d35fb0e
to
d8c21f3
Compare
Hrm. Compiling locally, the tests work fine. However, on GitHub Actions, both GCC and MSVC don't like the UTC-8 identifiers in the C++ code. I tried setting the This will need some more research to figure out! |
After some local testing, it appears that the gcc used in CI is the culprit. Changing No comment on the CMake equivalents, not familiar enough with that buildsystem. |
d8c21f3
to
3356a35
Compare
3356a35
to
536ea85
Compare
Thanks! I updated to Ubuntu 22.04, which we're using in the static checks already, and that fixes the Linux/GCC builds. I'm testing out some flags to fix the MSVC build. |
Huzzah! The MSVC flag I tried is working, so this is now fully passing tests :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see anything wrong with this, LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed at the GDExtension meeting. Changes look good.
Depends on PR godotengine/godot#96501