Implement typed dictionaries #1162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Repiteo
force-pushed
the
typed-dictionary
branch
from
eec44d2 to
191037d
Compare
Repiteo
force-pushed
the
typed-dictionary
branch
2 times, most recently
from
65f0881 to
f5b340a
Compare
Repiteo
force-pushed
the
typed-dictionary
branch
from
f5b340a to
ebf275e
Compare
Repiteo
force-pushed
the
typed-dictionary
branch
3 times, most recently
from
2775b10 to
fd05eca
Compare
Repiteo
force-pushed
the
typed-dictionary
branch
from
fd05eca to
2ffff66
Compare
dsnopek
added
the
enhancement
dsnopek
approved these changes
Sep 18, 2024
Zylann
reviewed
Sep 22, 2024
| @@ -2765,6 +2827,12 @@ def correct_typed_array(type_name): | |||
| return type_name | |||
|
|
|||
|
|
|||
| def correct_typed_dictionary(type_name): | |||
| fully_used_classes.add(dict_type_name) | ||
| else: | ||
| used_classes.add(dict_type_name) | ||
| dict_type_name = dict_type_names[2] |
There was a problem hiding this comment.
Why index 2? That would be the third entry. I think dictionary only have 2 types?
| fully_used_classes.add(dict_type_name) | ||
| else: | ||
| used_classes.add(dict_type_name) | ||
| dict_type_name = dict_type_names[2] |
There was a problem hiding this comment.
Why index 2? That would be the third entry. I think dictionary only have 2 types?
|
@Repiteo Any thoughts on Zylann's comments above? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A godot-cpp counterpart to PR godotengine/godot#78656
Tests/builds will fail until the above is merged, as this PR is dependant on it.