Skip to content

Commit

Permalink
clang: Add CallableCustomMethodPointerBase virtual destructor
Browse files Browse the repository at this point in the history
Fixes #1272
+ clang++ (debian v16/v17) warning:
	destructor called on
	'godot::CallableCustomMethodPointerBase' that is abstract but has non-virtual destructor
	[-Wdelete-abstract-non-virtual-dtor]
  • Loading branch information
capnm committed Oct 19, 2023
1 parent 64eac01 commit a926b96
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions include/godot_cpp/variant/callable_method_pointer.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ class CallableCustomMethodPointerBase {
public:
virtual Object *get_object() const = 0;
virtual void call(const Variant **p_arguments, int p_argcount, Variant &r_return_value, GDExtensionCallError &r_call_error) const = 0;
virtual ~CallableCustomMethodPointerBase() {}
};

namespace internal {
Expand Down

0 comments on commit a926b96

Please sign in to comment.