feat: support React 18 and use the npm registry #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmarkins-godaddy
approved these changes
Mar 21, 2024
| @@ -32,7 +32,7 @@ | |||
| "storybook": "start-storybook" | |||
| }, | |||
| "peerDependencies": { | |||
| "react": "^15.0.0 || ^16.0.0 || ^17.0.0" | |||
| "react": "15.x || 16.x || 17.x || 18.x" | |||
There was a problem hiding this comment.
I wouldn't even bother with supporting 15 & 16 IMO, but this is fine
rxmarbles
requested review from
chinrichs-godaddy,
3rd-Eden,
kinetifex,
jcrugzz and
Swaagie
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the package.json to allow React 18 as a peer dependency, along with any of the previous versions of React. While I'm here, I noticed that the package locks were all tied to Artifactory and not the public npm registry, which means the general public cannot install this as-is. I've updated that to pull all dependencies from the public npm registry.