Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add browserslist and config to ignore IE #58

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

add browserslist and config to ignore IE #58

wants to merge 2 commits into from

Conversation

vuchl
Copy link

@vuchl vuchl commented Oct 29, 2020

Targets #55

rxmarbles
rxmarbles reviewed Oct 29, 2020
View reviewed changes
Copy link
Member

@rxmarbles rxmarbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Theres a bit more that needs to be done to make this component not generate ES2015, we need to remove ES2015 babel plugins would you care to tackle that in this PR as well?

@vuchl
Copy link
Author

vuchl commented Oct 30, 2020

@rxmarbles I reconned that the only babel plugin was https://babeljs.io/docs/en/babel-plugin-syntax-dynamic-import

I removed it, and also rearranged some configuration accroding to the docs. Leave me a hint of what is missing.

Base automatically changed from master to main February 3, 2021 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rxmarbles rxmarbles rxmarbles left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vuchl @rxmarbles