Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cli fix #991

Merged
merged 3 commits into from
Dec 12, 2024
Merged

Cli fix #991

merged 3 commits into from
Dec 12, 2024

Conversation

mmason2-godaddy
Copy link
Contributor

Summary

Fix issue where the Commander instance was parsing the CLI args more than once during create.

Changelog

  • Add logic to the ready hook of the command plugin to only parse when the gasket.config.command is present
  • Fixup dynamic-plugins plugin prepare hook to return the config

Test Plan

Updated tests

@mmason2-godaddy mmason2-godaddy requested a review from a team as a code owner December 12, 2024 19:36
@mmason2-godaddy mmason2-godaddy merged commit 17e3857 into next Dec 12, 2024
2 checks passed
@mmason2-godaddy mmason2-godaddy deleted the cli-fix branch December 12, 2024 21:44
agerard-godaddy pushed a commit that referenced this pull request Dec 18, 2024
@mmason2-godaddy @agerard-godaddy
Cli fix (#991)
ef41ce2 
* Return config from prepare hook

* Tune command plugin ready hook parse logic

* tune prepare hook
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpina1-godaddy jpina1-godaddy jpina1-godaddy approved these changes

@agerard-godaddy agerard-godaddy agerard-godaddy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmason2-godaddy @agerard-godaddy @jpina1-godaddy