-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PFX-507] Add DocSearch to Gasket Site #984
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpina1-godaddy
approved these changes
Dec 5, 2024
agerard-godaddy
approved these changes
Dec 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of small nits then 👍
agerard-godaddy
pushed a commit
that referenced
this pull request
Dec 11, 2024
mmason2-godaddy
added a commit
that referenced
this pull request
Dec 11, 2024
* [PFX-813] ESM: Port plugin-metadata (#978) * chore: convert to esm * tests: added vitest * chore: update changelog; remove jest deps * fix: test * chore: remove unused space * [PFX-793] Dynamic plugins (#970) * feat: dynamic plugins * chore: add cjs tranpilation * tests: default-plugins * tests: core * tests: dynamic index * tests: prepare hook * fix: lint * chore: add types for dynamic plugins * docs: dynamic plugins * chore: update package.json * docs: update changelog * chore: switch to utilize sub-environments * chore: add metadata * fix: lint * fix: test * chore: remove cjs transpilation * docs: update dynamic and core * fix: test * Update packages/gasket-plugin-dynamic-plugins/README.md Co-authored-by: Andrew Gerard <[email protected]> --------- Co-authored-by: Andrew Gerard <[email protected]> * chore: remove depreacted http2 dep (#981) * Normalized gasket request (#973) * feat: normalized gasket request * fix: attempt types adjustments * fix: types adjustments * test: the things * docs: package docs * fix: docs * fix: one way to make * fix: ensure expected defaults * fix: better types * fix: handle parallel executions * fix: next request helper * test: adjustments * fix: unused import * feat: add WeakPromiseKeeper for consistent promise to value caching * fix: types * fix: docs * feat: handle IncomingMessage url * fix: tighten types * fix: test cruft * docs: fix * fix: only parse url when needed * test: using gasket.symbol as weakmap key (#964) * Separate https-proxy plugin (#982) * feat: separate https-proxy plugin * feat: use https-proxy with prompts * fix: typos and grammar * fix: avoid default export * fix: return proxy server * chore: upgrade lerna * fix: publish issues for command plugin * docs: next.config.js (#987) * [PFX-507] Add DocSearch to Gasket Site (#984) * change dynamic require to string interpolation (#985) * pin react-intl version to 6.6.X (#988) * feat: initial fixup for getting command name early and using prepare lifecycle as an async config * Fix typo * Tune types * Opt for sync configure hook * Clean up old references to command.id * Add isReady, update command property * Update readme * Tune command plugin functionality * Add temp logging for debug * Cleanup debugs * Persist commands config when commandId is undefined * Tune tests * lockfile * remove duplicate tests from merge * lockfile * lockfile * feat: initial fixup for getting command name early and using prepare lifecycle as an async config * Fix typo * Tune types * Opt for sync configure hook * Clean up old references to command.id * Add isReady, update command property * Update readme * Tune command plugin functionality * Add temp logging for debug * Cleanup debugs * Persist commands config when commandId is undefined * Tune tests * Import plugin command types * Relax the regex for gasket file in argv * Remove timing from ready hook * fix test --------- Co-authored-by: Jordan Pina <[email protected]> Co-authored-by: Andrew Gerard <[email protected]> Co-authored-by: Andrew Gerard <[email protected]> Co-authored-by: Kawika Bader <[email protected]> Co-authored-by: bbetts-godaddy <[email protected]>
agerard-godaddy
added a commit
that referenced
this pull request
Dec 18, 2024
* [PFX-813] ESM: Port plugin-metadata (#978) * chore: convert to esm * tests: added vitest * chore: update changelog; remove jest deps * fix: test * chore: remove unused space * [PFX-793] Dynamic plugins (#970) * feat: dynamic plugins * chore: add cjs tranpilation * tests: default-plugins * tests: core * tests: dynamic index * tests: prepare hook * fix: lint * chore: add types for dynamic plugins * docs: dynamic plugins * chore: update package.json * docs: update changelog * chore: switch to utilize sub-environments * chore: add metadata * fix: lint * fix: test * chore: remove cjs transpilation * docs: update dynamic and core * fix: test * Update packages/gasket-plugin-dynamic-plugins/README.md Co-authored-by: Andrew Gerard <[email protected]> --------- Co-authored-by: Andrew Gerard <[email protected]> * chore: remove depreacted http2 dep (#981) * Normalized gasket request (#973) * feat: normalized gasket request * fix: attempt types adjustments * fix: types adjustments * test: the things * docs: package docs * fix: docs * fix: one way to make * fix: ensure expected defaults * fix: better types * fix: handle parallel executions * fix: next request helper * test: adjustments * fix: unused import * feat: add WeakPromiseKeeper for consistent promise to value caching * fix: types * fix: docs * feat: handle IncomingMessage url * fix: tighten types * fix: test cruft * docs: fix * fix: only parse url when needed * test: using gasket.symbol as weakmap key (#964) * Separate https-proxy plugin (#982) * feat: separate https-proxy plugin * feat: use https-proxy with prompts * fix: typos and grammar * fix: avoid default export * fix: return proxy server * chore: upgrade lerna * fix: publish issues for command plugin * docs: next.config.js (#987) * [PFX-507] Add DocSearch to Gasket Site (#984) * change dynamic require to string interpolation (#985) * pin react-intl version to 6.6.X (#988) * feat: initial fixup for getting command name early and using prepare lifecycle as an async config * Fix typo * Tune types * Opt for sync configure hook * Clean up old references to command.id * Add isReady, update command property * Update readme * Tune command plugin functionality * Add temp logging for debug * Cleanup debugs * Persist commands config when commandId is undefined * Tune tests * lockfile * remove duplicate tests from merge * lockfile * lockfile * feat: initial fixup for getting command name early and using prepare lifecycle as an async config * Fix typo * Tune types * Opt for sync configure hook * Clean up old references to command.id * Add isReady, update command property * Update readme * Tune command plugin functionality * Add temp logging for debug * Cleanup debugs * Persist commands config when commandId is undefined * Tune tests * Import plugin command types * Relax the regex for gasket file in argv * Remove timing from ready hook * fix test --------- Co-authored-by: Jordan Pina <[email protected]> Co-authored-by: Andrew Gerard <[email protected]> Co-authored-by: Andrew Gerard <[email protected]> Co-authored-by: Kawika Bader <[email protected]> Co-authored-by: bbetts-godaddy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The Gasket site (gasket.dev) does not currently have search functionality.
Changelog
Added DocSearch
Test Plan
Updated tests.