Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PFX-507] Add DocSearch to Gasket Site #984

Merged
merged 8 commits into from
Dec 6, 2024
Merged

[PFX-507] Add DocSearch to Gasket Site #984

merged 8 commits into from
Dec 6, 2024

Conversation

kbader-godaddy
Copy link
Contributor

Summary

The Gasket site (gasket.dev) does not currently have search functionality.

Changelog

Added DocSearch

Test Plan

Updated tests.

@kbader-godaddy kbader-godaddy requested a review from a team as a code owner December 4, 2024 21:49
packages/gasket-plugin-command/README.md Outdated Show resolved Hide resolved
packages/gasket-plugin-command/README.md Outdated Show resolved Hide resolved
packages/gasket-plugin-command/README.md Outdated Show resolved Hide resolved
packages/gasket-plugin-command/README.md Outdated Show resolved Hide resolved
packages/gasket-plugin-command/README.md Outdated Show resolved Hide resolved
packages/gasket-plugin-command/README.md Outdated Show resolved Hide resolved
packages/gasket-plugin-command/README.md Outdated Show resolved Hide resolved
@kbader-godaddy kbader-godaddy requested review from a team December 5, 2024 15:28
packages/gasket-utils/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@agerard-godaddy agerard-godaddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of small nits then 👍

@kbader-godaddy kbader-godaddy merged commit 807f4e6 into main Dec 6, 2024
2 checks passed
@kbader-godaddy kbader-godaddy deleted the docsearch branch December 6, 2024 21:23
mmason2-godaddy added a commit that referenced this pull request Dec 11, 2024
* [PFX-813] ESM: Port plugin-metadata (#978)

* chore: convert to esm

* tests: added vitest

* chore: update changelog; remove jest deps

* fix: test

* chore: remove unused space

* [PFX-793] Dynamic plugins (#970)

* feat: dynamic plugins

* chore: add cjs tranpilation

* tests: default-plugins

* tests: core

* tests: dynamic index

* tests: prepare hook

* fix: lint

* chore: add types for dynamic plugins

* docs: dynamic plugins

* chore: update package.json

* docs: update changelog

* chore: switch to utilize sub-environments

* chore: add metadata

* fix: lint

* fix: test

* chore: remove cjs transpilation

* docs: update dynamic and core

* fix: test

* Update packages/gasket-plugin-dynamic-plugins/README.md

Co-authored-by: Andrew Gerard <[email protected]>

---------

Co-authored-by: Andrew Gerard <[email protected]>

* chore: remove depreacted http2 dep (#981)

* Normalized gasket request (#973)

* feat: normalized gasket request

* fix: attempt types adjustments

* fix: types adjustments

* test: the things

* docs: package docs

* fix: docs

* fix: one way to make

* fix: ensure expected defaults

* fix: better types

* fix: handle parallel executions

* fix: next request helper

* test: adjustments

* fix: unused import

* feat: add WeakPromiseKeeper for consistent promise to value caching

* fix: types

* fix: docs

* feat: handle IncomingMessage url

* fix: tighten types

* fix: test cruft

* docs: fix

* fix: only parse url when needed

* test: using gasket.symbol as weakmap key (#964)

* Separate https-proxy plugin (#982)

* feat: separate https-proxy plugin

* feat: use https-proxy with prompts

* fix: typos and grammar

* fix: avoid default export

* fix: return proxy server

* chore: upgrade lerna

* fix: publish issues for command plugin

* docs: next.config.js (#987)

* [PFX-507] Add DocSearch to Gasket Site (#984)

* change dynamic require to string interpolation (#985)

* pin react-intl version to 6.6.X (#988)

* feat: initial fixup for getting command name early and using prepare lifecycle as an async config

* Fix typo

* Tune types

* Opt for sync configure hook

* Clean up old references to command.id

* Add isReady, update command property

* Update readme

* Tune command plugin functionality

* Add temp logging for debug

* Cleanup debugs

* Persist commands config when commandId is undefined

* Tune tests

* lockfile

* remove duplicate tests from merge

* lockfile

* lockfile

* feat: initial fixup for getting command name early and using prepare lifecycle as an async config

* Fix typo

* Tune types

* Opt for sync configure hook

* Clean up old references to command.id

* Add isReady, update command property

* Update readme

* Tune command plugin functionality

* Add temp logging for debug

* Cleanup debugs

* Persist commands config when commandId is undefined

* Tune tests

* Import plugin command types

* Relax the regex for gasket file in argv

* Remove timing from ready hook

* fix test

---------

Co-authored-by: Jordan Pina <[email protected]>
Co-authored-by: Andrew Gerard <[email protected]>
Co-authored-by: Andrew Gerard <[email protected]>
Co-authored-by: Kawika Bader <[email protected]>
Co-authored-by: bbetts-godaddy <[email protected]>
agerard-godaddy added a commit that referenced this pull request Dec 18, 2024
* [PFX-813] ESM: Port plugin-metadata (#978)

* chore: convert to esm

* tests: added vitest

* chore: update changelog; remove jest deps

* fix: test

* chore: remove unused space

* [PFX-793] Dynamic plugins (#970)

* feat: dynamic plugins

* chore: add cjs tranpilation

* tests: default-plugins

* tests: core

* tests: dynamic index

* tests: prepare hook

* fix: lint

* chore: add types for dynamic plugins

* docs: dynamic plugins

* chore: update package.json

* docs: update changelog

* chore: switch to utilize sub-environments

* chore: add metadata

* fix: lint

* fix: test

* chore: remove cjs transpilation

* docs: update dynamic and core

* fix: test

* Update packages/gasket-plugin-dynamic-plugins/README.md

Co-authored-by: Andrew Gerard <[email protected]>

---------

Co-authored-by: Andrew Gerard <[email protected]>

* chore: remove depreacted http2 dep (#981)

* Normalized gasket request (#973)

* feat: normalized gasket request

* fix: attempt types adjustments

* fix: types adjustments

* test: the things

* docs: package docs

* fix: docs

* fix: one way to make

* fix: ensure expected defaults

* fix: better types

* fix: handle parallel executions

* fix: next request helper

* test: adjustments

* fix: unused import

* feat: add WeakPromiseKeeper for consistent promise to value caching

* fix: types

* fix: docs

* feat: handle IncomingMessage url

* fix: tighten types

* fix: test cruft

* docs: fix

* fix: only parse url when needed

* test: using gasket.symbol as weakmap key (#964)

* Separate https-proxy plugin (#982)

* feat: separate https-proxy plugin

* feat: use https-proxy with prompts

* fix: typos and grammar

* fix: avoid default export

* fix: return proxy server

* chore: upgrade lerna

* fix: publish issues for command plugin

* docs: next.config.js (#987)

* [PFX-507] Add DocSearch to Gasket Site (#984)

* change dynamic require to string interpolation (#985)

* pin react-intl version to 6.6.X (#988)

* feat: initial fixup for getting command name early and using prepare lifecycle as an async config

* Fix typo

* Tune types

* Opt for sync configure hook

* Clean up old references to command.id

* Add isReady, update command property

* Update readme

* Tune command plugin functionality

* Add temp logging for debug

* Cleanup debugs

* Persist commands config when commandId is undefined

* Tune tests

* lockfile

* remove duplicate tests from merge

* lockfile

* lockfile

* feat: initial fixup for getting command name early and using prepare lifecycle as an async config

* Fix typo

* Tune types

* Opt for sync configure hook

* Clean up old references to command.id

* Add isReady, update command property

* Update readme

* Tune command plugin functionality

* Add temp logging for debug

* Cleanup debugs

* Persist commands config when commandId is undefined

* Tune tests

* Import plugin command types

* Relax the regex for gasket file in argv

* Remove timing from ready hook

* fix test

---------

Co-authored-by: Jordan Pina <[email protected]>
Co-authored-by: Andrew Gerard <[email protected]>
Co-authored-by: Andrew Gerard <[email protected]>
Co-authored-by: Kawika Bader <[email protected]>
Co-authored-by: bbetts-godaddy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants