Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for dynamic plugins with commands #1016

Merged
merged 13 commits into from
Jan 23, 2025
Merged

Conversation

agerard-godaddy
Copy link
Contributor

Summary

Improvements to using commands with dynamic plugins, providing better debugging and error reporting.

Changelog

@gasket/plugin-command

  • Invoke commands lifecycles during prepare
  • Always register the command called; not filtered by what's been registered

@gasket/plugin-dynamic-plugins

  • Set timing before commands plugins to allow dynamic plugins to register commands
  • Add 'deduped' trace for improved lifecycle debugging
  • Invoke prepare lifecycle of dynamic plugins

Test Plan

Testing in a local app

@agerard-godaddy agerard-godaddy requested a review from a team as a code owner January 21, 2025 23:03
@agerard-godaddy agerard-godaddy added the minor Scheduled for minor release version label Jan 22, 2025
@agerard-godaddy agerard-godaddy merged commit 2749b90 into main Jan 23, 2025
2 checks passed
@agerard-godaddy agerard-godaddy deleted the fix-dynamic-cmds branch January 23, 2025 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Scheduled for minor release version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants