Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PFX-833] Remove Default Plugins #1014

Merged
merged 4 commits into from
Jan 23, 2025
Merged

[PFX-833] Remove Default Plugins #1014

merged 4 commits into from
Jan 23, 2025
+105 −108

Conversation

kbader-godaddy
Copy link
Contributor

Summary

We have decided to retire the concept of default plugins, and instead simply add these plugins directly to the presets.

Changelog

  • Remove default plugins

Test Plan

Tests updated.

@kbader-godaddy kbader-godaddy requested a review from a team as a code owner January 17, 2025 22:22
@kbader-godaddy kbader-godaddy requested review from a team January 17, 2025 22:42
agerard-godaddy
agerard-godaddy requested changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@agerard-godaddy agerard-godaddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not need the extra prompt exports and direct calls. Just including the former "default plugins" with the preset configs should be enough.

packages/gasket-plugin-docs/package.json Outdated Show resolved Hide resolved
packages/gasket-preset-api/lib/preset-prompt.js Outdated Show resolved Hide resolved
@agerard-godaddy agerard-godaddy added the minor Scheduled for minor release version label Jan 22, 2025
@kbader-godaddy kbader-godaddy merged commit d429aec into main Jan 23, 2025
2 checks passed
@kbader-godaddy kbader-godaddy deleted the PFX-833-min branch January 23, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agerard-godaddy agerard-godaddy agerard-godaddy approved these changes

@rxmarbles rxmarbles rxmarbles approved these changes

@3rd-Eden 3rd-Eden Awaiting requested review from 3rd-Eden

Assignees
No one assigned
Labels
minor Scheduled for minor release version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kbader-godaddy @rxmarbles @agerard-godaddy @kawikabader