[PFX-409] - Cleanup deprecated: @gasket/plugin-nextjs (#655)

* chore: removed next config support * chore: updated changelog
godaddy · Jan 22, 2024 · 02af3b4 · 02af3b4
1 parent 0da8c6e
commit 02af3b4
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 18 deletions.
diff --git a/packages/gasket-plugin-nextjs/CHANGELOG.md b/packages/gasket-plugin-nextjs/CHANGELOG.md
@@ -1,5 +1,7 @@
 # `@gasket/plugin-nextjs`
 
+- Removed support for deprecated `next` config support ([#655])
+
 ### 6.43.0
 
 - Upgrade to Next.js 13.1.1 ([#614])
@@ -240,3 +242,4 @@
 [#541]: https://github.com/godaddy/gasket/pull/541
 [#556]: https://github.com/godaddy/gasket/pull/556
 [#614]: https://github.com/godaddy/gasket/pull/614
+[#655]: https://github.com/godaddy/gasket/pull/655
diff --git a/packages/gasket-plugin-nextjs/lib/index.js b/packages/gasket-plugin-nextjs/lib/index.js
@@ -29,18 +29,13 @@ module.exports = {
         first: true // Fixup next -> nextConfig early for reference by other plugins
       },
       handler: function configure(gasket, baseConfig = {}) {
-        const { logger } = gasket;
-        const { next, ...rest } = baseConfig;
-        if (next) {
-          logger.warning('DEPRECATED `next` in Gasket config - use `nextConfig`');
-        }
-        const { nextConfig = next || {} } = baseConfig;
+        const { nextConfig = {} } = baseConfig;
 
         const serviceWorker = {
           webpackRegister: (key) => /_app/.test(key),
           ...(baseConfig.serviceWorker || {})
         };
-        return { ...rest, serviceWorker, nextConfig };
+        return { ...baseConfig, serviceWorker, nextConfig };
       }
     },
     async prompt(gasket, context, { prompt }) {

diff --git a/packages/gasket-plugin-nextjs/test/index.test.js b/packages/gasket-plugin-nextjs/test/index.test.js
@@ -93,17 +93,6 @@ describe('configure hook', () => {
     expect(entryName('_app')).toEqual(true);
     expect(entryName('static/runtime/_app')).toEqual(true);
   });
-
-  it('fallback support for `next` from gasket.config', async () => {
-    const gasket = mockGasketApi();
-    delete gasket.config.nextConfig;
-    gasket.config.next = {
-      customConfig: true
-    };
-    const results = configureHook(gasket, gasket.config);
-    expect(results.nextConfig).toHaveProperty('customConfig', true);
-    expect(gasket.logger.warning).toHaveBeenCalledWith(expect.stringContaining('DEPRECATED'));
-  });
 });
 
 describe('express hook', () => {