Fix GDL Convert() internal function for compatibility with ARM64 #1949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or error gnudatalanguage#1874 Addditionnally it was found that multithreading may have been wrongly activated during those conversions to string, the code now checks GDL_NTHREADS value.
…nes. enables arm64 for test_byte_conversion, test_bytscl and test_formats removed printing and comparison of NaN and Inf formats by default in test_formats (use option /with_nans added to GENERATE_FORMAT_FILE for that)
GillesDuvert
changed the title
|
As a result, test_byte_conversion, test_bytscl and test_formats were reenabled for ARM64 machines. |
|
One thing that will NOT be the same is related to Infinity and NaN conversion to integer, that cannot be solved easily. |
GillesDuvert
deleted the
close_1874_Ulong_and_Uint_StringConversionWrong
branch
This was referenced Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRINT, PRINTF, STRING, STRTRIM, all formats ... depend on C/C++ casting to different types.
This PR modifies the Convert() function to get similar results on X86_64 and AARCH64 (ARM64, M1,M2...) when needed (conversion of a float/double towards unsigned integer types)
This to solve 99% of #1881 , #1877 and #1842 but see #1948
Besides, snprintf format was 'i' and not 'u' in Ulong and Uint --- this made for error #1874
Addditionnally it was found that multithreading in Convert() may have been wrongly activated during some conversions, the code now checks GDL_NTHREADS value everywhere (?). Could potentially speedup things.