-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Replaced deprecated --compress 2 option with new JLink 21 compliant --compress zip-9 #743
Conversation
Going through the
I am wondering if we should default to |
At least for Windows, it has no effect. I have not tested Linux an macOS builds yet.
|
Reverted to zip-6 as this is the equivalent to formerly used 2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, I tried both zip-6 and zip-9 on mac m1 with JDK 23.
With zip-6 the runtime created is 148.1MB (14,78,75,131 bytes) and with zip-9 it is 148MB (14,78,17,824 bytes).
Interesting! The extacted contents of the 80 MiB MSI file is 155 MiB on Windows. I would have expected a smaller file size on Linux (at least for the package file). |
I was talking about the runtime which is created after running the jlink command. |
Ah, yes, my mistake. |
As with JLink 21 the option
--compress 2
is deprecated,--compress zip-9
is used instead.Issue
Fixes #741
Progress