-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix static group criteria #439
Fix static group criteria #439
Conversation
Last commit use instead of backup / restore |
Co-authored-by: Johan Cwiklinski <[email protected]>
Co-authored-by: Johan Cwiklinski <[email protected]>
is it possibile that with this commit now the dynamic and static group search (criteria) get resetted? |
I've adapted the PR to keep the same search behavior on dynamic groups, as the search is saved in the database. It won't be possible to do the same for static groups. |
I think that can be fair... as to add computer to static groups we can use the "regular search" and then add selected to specific static group. tomorrow morning I'm going to test it. thank you |
I confirm it is working as expected now |
Try to fix #430
Search from static group is a litlle bit different than "Computer" search (Glpiinventory plugin use it's own derived class
PluginGlpiinventoryComputer
)PluginGlpiinventoryComputer
is mainly used to override standard massiveaction and get only one "Add to static group or "Remove from static group".First commit allow saerch engine to correctly compute SQL query based on
Computer
Second commit backup and restore
$_SESSION['glpisearch']['Computer']
to prevent the search carried out in the static group from overwriting the last search carried out on the Computer.