Fix direct query

glpi-project · Oct 27, 2023 · eb441c7 · eb441c7
1 parent 883f59d
commit eb441c7
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 8 deletions.
diff --git a/inc/deploypackage_profile.class.php b/inc/deploypackage_profile.class.php
@@ -95,11 +95,15 @@ public static function getProfiles($deploypackages_id)
         global $DB;
 
         $prof  = [];
-        $query = "SELECT `glpi_plugin_glpiinventory_deploypackages_profiles`.*
-                FROM `glpi_plugin_glpiinventory_deploypackages_profiles`
-                WHERE `plugin_glpiinventory_deploypackages_id` = '$deploypackages_id'";
 
-        foreach ($DB->request($query) as $data) {
+        $iterator = $DB->request([
+            'FROM' => 'glpi_plugin_glpiinventory_deploypackages_profiles',
+            'WHERE' => [
+                'plugin_glpiinventory_deploypackages_id' => $deploypackages_id
+            ]
+        ]);
+
+        foreach ($iterator as $data) {
             $prof[$data['profiles_id']][] = $data;
         }
         return $prof;

diff --git a/tests/Integration/Tasks/CronTaskTest.php b/tests/Integration/Tasks/CronTaskTest.php
@@ -705,10 +705,12 @@ public function cleanTasksAndJobs()
        //Prepare the task
         PluginGlpiinventoryTask::cronTaskscheduler();
 
-       //Set the first job as successfull
-        $query = "SELECT DISTINCT `plugin_glpiinventory_taskjobstates_id`
-                FROM glpi_plugin_glpiinventory_taskjoblogs LIMIT 1";
-        foreach ($DB->request($query) as $data) {
+        //Set the first job as successfull
+        $iterator = $DB->request([
+            'FROM' => 'glpi_plugin_glpiinventory_taskjoblogs',
+            'LIMIT' => 1
+        ]);
+        foreach ($iterator as $data) {
             $pfTaskJobstate->changeStatusFinish($data['plugin_glpiinventory_taskjobstates_id'], 0, '');
         }