Added warning if flow is not published #3142
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://deploy-preview-3142--glific-frontend.netlify.app |
Glific
|
||||||||||||||||||||||||||||
| Project |
Glific
|
| Branch Review |
enhancement/flow-warning
|
| Run status |
|
| Run duration | 24m 59s |
| Commit |
|
| Committer | Akansha Sakhre |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
169
|
| View all changes introduced in this branch ↗︎ | |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3142 +/- ##
==========================================
+ Coverage 81.73% 81.80% +0.06%
==========================================
Files 329 329
Lines 10564 10575 +11
Branches 2235 2239 +4
==========================================
+ Hits 8635 8651 +16
+ Misses 1316 1311 -5
Partials 613 613 ☔ View full report in Codecov by Sentry. |
kurund
requested changes
Nov 25, 2024
kurund
reviewed
Dec 10, 2024
There was a problem hiding this comment.
I don't see any warning message.
Steps that I followed.
- created new flow and published
- tried editing the above flow and remove some node and clicked on menu links it navigated to the same without any warning.
May be I am missing something. Lets discuss during our call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
target issue is #3115