Merge pull request #18525 from github/oscarsj/upgrade-workflows-to-ub…

…untu24 Upgrade workflows to ubuntu-24
github · Jan 22, 2025 · ebb10e3 · ebb10e3
2 parents 28f3073 + 4fb2273
commit ebb10e3
Show file tree

Hide file tree

Showing 15 changed files with 9 additions and 119 deletions.
diff --git a/.devcontainer/swift/Dockerfile b/.devcontainer/swift/Dockerfile
diff --git a/.devcontainer/swift/devcontainer.json b/.devcontainer/swift/devcontainer.json
diff --git a/.devcontainer/swift/root.sh b/.devcontainer/swift/root.sh
diff --git a/.devcontainer/swift/update-codeql.sh b/.devcontainer/swift/update-codeql.sh
diff --git a/.devcontainer/swift/user.sh b/.devcontainer/swift/user.sh
diff --git a/.github/workflows/swift.yml b/.github/workflows/swift.yml
@@ -48,12 +48,6 @@ jobs:
     steps:
       - uses: actions/checkout@v4
       - uses: ./swift/actions/build-and-test
-  build-and-test-linux:
-    if: github.repository_owner == 'github'
-    runs-on: ubuntu-22.04
-    steps:
-      - uses: actions/checkout@v4
-      - uses: ./swift/actions/build-and-test
   qltests-macos:
     if: ${{ github.repository_owner == 'github' && github.event_name == 'pull_request' }}
     needs: build-and-test-macos

diff --git a/actions/ql/test/query-tests/Security/CWE-094/.github/workflows/self_needs.yml b/actions/ql/test/query-tests/Security/CWE-094/.github/workflows/self_needs.yml
@@ -6,7 +6,7 @@ on:
 
 jobs:
   test1:
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     outputs:
       job_output: ${{ steps.source.outputs.value }}
     steps:

diff --git a/actions/ql/test/query-tests/Security/CWE-094/.github/workflows/test10.yml b/actions/ql/test/query-tests/Security/CWE-094/.github/workflows/test10.yml
@@ -491,7 +491,7 @@ jobs:
 
   send_results:
     name: Send results to webhook
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     if: always()
     needs: [
         setup,

diff --git a/actions/ql/test/query-tests/Security/CWE-094/.github/workflows/test23.yml b/actions/ql/test/query-tests/Security/CWE-094/.github/workflows/test23.yml
@@ -3,7 +3,7 @@ on:
 
 jobs:
   test:
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     if: >
       (github.event.workflow_run.event == 'pull_request' ||
       github.event.workflow_run.event == 'pull_request_target') &&

diff --git a/actions/ql/test/query-tests/Security/CWE-094/.github/workflows/test24.yml b/actions/ql/test/query-tests/Security/CWE-094/.github/workflows/test24.yml
@@ -3,7 +3,7 @@ on:
 
 jobs:
   test:
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     steps:
       - name: Run Issue form parser
         id: parse

diff --git a/actions/ql/test/query-tests/Security/CWE-829/.github/workflows/issue_comment_octokit.yml b/actions/ql/test/query-tests/Security/CWE-829/.github/workflows/issue_comment_octokit.yml
@@ -7,7 +7,7 @@ on:
 jobs:
   test1: 
     if: github.event.comment.body == '@metabase-bot run visual tests'
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     steps:
       - name: Fetch issue
         uses: octokit/[email protected]

diff --git a/actions/ql/test/query-tests/Security/CWE-829/.github/workflows/issue_comment_octokit2.yml b/actions/ql/test/query-tests/Security/CWE-829/.github/workflows/issue_comment_octokit2.yml
@@ -7,7 +7,7 @@ on:
 jobs:
   test1:
     if: github.event.comment.body == '@metabase-bot run visual tests'
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     steps:
       - name: Fetch issue
         uses: octokit/[email protected]

diff --git a/...s/Violations Of Best Practice/CodeQL/.github/workflows/should_be_using_advanced_setup.yml b/...s/Violations Of Best Practice/CodeQL/.github/workflows/should_be_using_advanced_setup.yml
@@ -21,9 +21,9 @@ jobs:
       matrix:
         include:
           - language: javascript
-            os: ubuntu-22.04
+            os: ubuntu-24.04
           - language: ruby
-            os: ubuntu-22.04-16core
+            os: ubuntu-24.04-16core
 
     steps:
       - name: Checkout repository

diff --git a/csharp/ql/integration-tests/all-platforms/autobuild/autobuild.csproj b/csharp/ql/integration-tests/all-platforms/autobuild/autobuild.csproj
@@ -3,7 +3,6 @@
   <PropertyGroup>
     <OutputType>Exe</OutputType>
     <TargetFramework>net5.0</TargetFramework>
-    <ImplicitUsings>enable</ImplicitUsings>
     <Nullable>enable</Nullable>
   </PropertyGroup>
 

diff --git a/csharp/ql/integration-tests/all-platforms/autobuild/global.json b/csharp/ql/integration-tests/all-platforms/autobuild/global.json
@@ -1,5 +1,5 @@
 {
     "sdk": {
-        "version": "5.0.408"
+        "version": "9.0.100"
     }
 }