forked from msys2/MINGW-packages
-
Notifications
You must be signed in to change notification settings - Fork 46
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
As of OpenSSL v3.1.4, there is a pair of new test failures in 05-test_rand. The symptom looks like this: Engine "ossltest" set. ../../util/wrap.pl ../../apps/openssl.exe rand -engine ossltest -hex 16 => 0 not ok 4 - rand with ossltest: Check rand output is as expected # Failed test 'rand with ossltest: Check rand output is as expected' # at ../openssl-3.1.4/test/recipes/05-test_rand.t line 32. Engine "dasync" set. ../../util/wrap.pl ../../apps/openssl.exe rand -engine dasync -hex 16 => 0 not ok 5 - rand with dasync: Check rand output is of expected length The two failing tests both spawn an engine, which by virtue of being MINGW `.dll` files use CR/LF when printing to `stdout`. To accommodate for that, use the same "better chomp" as elsewhere in OpenSSL's source code. Signed-off-by: Johannes Schindelin <[email protected]>
- Loading branch information
Showing
2 changed files
with
43 additions
and
1 deletion.
There are no files selected for viewing
39 changes: 39 additions & 0 deletions
39
mingw-w64-openssl/0001-test_rand-use-the-better-chomp.patch
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
From 820803594c31daa2c96921f2d7888c88b1edc97e Mon Sep 17 00:00:00 2001 | ||
From: Johannes Schindelin <[email protected]> | ||
Date: Wed, 25 Oct 2023 17:10:17 +0200 | ||
Subject: [PATCH] test_rand: use the "better chomp" | ||
|
||
Following in the footsteps of | ||
https://github.com/openssl/openssl/commit/9ba96fbb2523cb12747c559c704c58bd8f9e7982 | ||
(Perl's chop / chomp considered bad, use a regexp instead, 2016-02-11), | ||
let's not use `chomp()` here because it would leave Carriage Returns in | ||
place, making the test fail in the MINGW build on Windows. | ||
|
||
Signed-off-by: Johannes Schindelin <[email protected]> | ||
--- | ||
test/recipes/05-test_rand.t | 4 ++-- | ||
1 file changed, 2 insertions(+), 2 deletions(-) | ||
|
||
diff --git a/test/recipes/05-test_rand.t b/test/recipes/05-test_rand.t | ||
index aa012c1..f2c1374 100644 | ||
--- a/test/recipes/05-test_rand.t | ||
+++ b/test/recipes/05-test_rand.t | ||
@@ -28,13 +28,13 @@ SKIP: { | ||
|
||
@randdata = run(app(['openssl', 'rand', '-engine', 'ossltest', '-hex', '16' ]), | ||
capture => 1, statusvar => \$success); | ||
- chomp(@randdata); | ||
+ $_ =~ s|\R+$|| for @randdata; | ||
ok($success && $randdata[0] eq $expected, | ||
"rand with ossltest: Check rand output is as expected"); | ||
|
||
@randdata = run(app(['openssl', 'rand', '-engine', 'dasync', '-hex', '16' ]), | ||
capture => 1, statusvar => \$success); | ||
- chomp(@randdata); | ||
+ $_ =~ s|\R+$|| for @randdata; | ||
ok($success && length($randdata[0]) == 32, | ||
"rand with dasync: Check rand output is of expected length"); | ||
} | ||
-- | ||
2.42.0.windows.2 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters