-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cp branch #8664
base: Competitive_Programming
Are you sure you want to change the base?
Cp branch #8664
Conversation
* Merge two arrays according to constraints added. * Create MagicNumber.md * Rename MagicNumber.md to NthMagicNumber.md * header file and heading added. * Rename Competitive_Programming/Python/Maths & Number Theory/MagicNumber/NthMagicNumber.md to Competitive_Programming/Python/Maths & Number Theory/NthMagicNumber/NthMagicNumber.md Co-authored-by: BootLook <[email protected]> Co-authored-by: Jinal4502 <[email protected]> Co-authored-by: Ahana Pal <[email protected]>
* Merge two arrays according to constraints added. * Create MagicNumber.md * Rename MagicNumber.md to NthMagicNumber.md * header file and heading added. * Rename Competitive_Programming/Python/Maths & Number Theory/MagicNumber/NthMagicNumber.md to Competitive_Programming/Python/Maths & Number Theory/NthMagicNumber/NthMagicNumber.md Co-authored-by: BootLook <[email protected]> Co-authored-by: Jinal4502 <[email protected]> Co-authored-by: Ahana Pal <[email protected]>
@ravireddy07 please review |
See @iam-sakshi I can't explain the same thing. As you can see, there are commits which already merged are present in this PR. You can just update your local branch which you raised this PR with the See, approving and merging is completely fine and it's bad practice for me to approve this kind of PR and bad practice for you to raise this kind of PR(s). This won't be a problem in this kind of projects, but it's a bad practice and might raise issues in other product based projects where each commit significes a change in the product/feature. That's all i can say. It's you're wish to learn or not. :)( |
updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the following things:
- Remove spaces in folder name and update the TLE to it's full form.
- Please add few more points like
cout
and'\n'
...etc
Description 📜
few ways to escape TLE in CP with C++
TLE in C++ #8663
Type of change 📝
Domain of Contribution 📊
Checklist ✅
Screenshots / Gif (Optional) 📸