Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release] change tag to main #1744

Merged
merged 1 commit into from
Dec 9, 2024
Merged

[release] change tag to main #1744

merged 1 commit into from
Dec 9, 2024

Conversation

MarcelKoch
Copy link
Member

No description provided.

@MarcelKoch MarcelKoch added this to the Ginkgo 1.9.0 milestone Dec 9, 2024
@MarcelKoch MarcelKoch requested a review from a team December 9, 2024 10:35
@MarcelKoch MarcelKoch self-assigned this Dec 9, 2024
@ginkgo-bot ginkgo-bot added the reg:build This is related to the build system. label Dec 9, 2024
@yhmtsai
Copy link
Member

yhmtsai commented Dec 9, 2024

Some readme link should use main not develop

@MarcelKoch MarcelKoch force-pushed the release-update-tag branch 2 times, most recently from f4cc8e6 to 4440594 Compare December 9, 2024 13:44
README.md Outdated
[![Build status](https://gitlab.com/ginkgo-project/ginkgo-public-ci/badges/develop/pipeline.svg)](https://gitlab.com/ginkgo-project/ginkgo-public-ci/-/pipelines?page=1&scope=branches&ref=develop)|[![OSX-build](https://github.com/ginkgo-project/ginkgo/actions/workflows/osx.yml/badge.svg)](https://github.com/ginkgo-project/ginkgo/actions/workflows/osx.yml)|[![codecov](https://codecov.io/gh/ginkgo-project/ginkgo/branch/develop/graph/badge.svg)](https://codecov.io/gh/ginkgo-project/ginkgo)|[![Maintainability Rating](https://sonarcloud.io/api/project_badges/measure?project=ginkgo-project_ginkgo&metric=sqale_rating)](https://sonarcloud.io/dashboard?id=ginkgo-project_ginkgo)|[![Reliability Rating](https://sonarcloud.io/api/project_badges/measure?project=ginkgo-project_ginkgo&metric=reliability_rating)](https://sonarcloud.io/dashboard?id=ginkgo-project_ginkgo)|[![CDash dashboard](https://img.shields.io/badge/CDash-Access-blue.svg)](https://my.cdash.org/index.php?project=Ginkgo+Project)
|:-:|:-:|:-:|:-:|:-:|:-:|
[![Build status](https://gitlab.com/ginkgo-project/ginkgo-public-ci/badges/main/pipeline.svg)](https://gitlab.com/ginkgo-project/ginkgo-public-ci/-/pipelines?page=1&scope=branches&ref=main)|[![OSX-build](https://github.com/ginkgo-project/ginkgo/actions/workflows/osx.yml/badge.svg)](https://github.com/ginkgo-project/ginkgo/actions/workflows/osx.yml)| [![codecov](https://codecov.io/gh/ginkgo-project/ginkgo/branch/main/graph/badge.svg)](https://codecov.io/gh/ginkgo-project/ginkgo) |[![Maintainability Rating](https://sonarcloud.io/api/project_badges/measure?project=ginkgo-project_ginkgo&metric=sqale_rating)](https://sonarcloud.io/dashboard?id=ginkgo-project_ginkgo)|[![Reliability Rating](https://sonarcloud.io/api/project_badges/measure?project=ginkgo-project_ginkgo&metric=reliability_rating)](https://sonarcloud.io/dashboard?id=ginkgo-project_ginkgo)|[![CDash dashboard](https://img.shields.io/badge/CDash-Access-blue.svg)](https://my.cdash.org/index.php?project=Ginkgo+Project)
|:-:|:-:|:----------------------------------------------------------------------------------------------------------------------------------:|:-:|:-:|:-:|
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason for additional dash here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

autoformatting. I have removed it

Copy link
Member

@pratikvn pratikvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MarcelKoch MarcelKoch merged commit 055344d into develop Dec 9, 2024
8 of 11 checks passed
@MarcelKoch MarcelKoch deleted the release-update-tag branch December 9, 2024 14:23
@ginkgo-bot
Copy link
Member

Error: PR already merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reg:build This is related to the build system.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants